GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cpu/intel/model_1067x: Implement microcode loading 

We load it once for the BSP in advance and let the MP init handle it for
the APs. The BSP load could also be done earlier, e.g. before CAR setup,
to align with other platforms.

TEST=Booted ThinkPad X200s and checked log: Microcode is loaded
     correctly on the BSP before SMM setup, and reported to be up
     to date on all cores after.

Change-Id: I85adb22a608ca3e7355bd486ebba52ec8fdd396c
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/31664
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Rudolph <siro@das-labor.org>
This commit is contained in:
Nico Huber 2019-02-28 22:57:16 +01:00
parent 97445f20ed
commit 2d0fe4ff22
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/cpu/intel/model_1067x/mp_init.c
View File

@ -27,6 +27,8 @@ static const void *microcode_patch;
static void pre_mp_init(void) static void pre_mp_init(void)
{ {
intel_microcode_load_unlocked(microcode_patch);
/* Setup MTRRs based on physical address size. */ /* Setup MTRRs based on physical address size. */
x86_setup_mtrrs_with_detect(); x86_setup_mtrrs_with_detect();
x86_mtrr_check(); x86_mtrr_check();
@ -42,6 +44,12 @@ static int get_cpu_count(void)
return cores; return cores;
} }
static void get_microcode_info(const void **microcode, int *parallel)
{
*microcode = microcode_patch;
*parallel = 1;
}
/* the SMRR enable and lock bit need to be set in IA32_FEATURE_CONTROL /* the SMRR enable and lock bit need to be set in IA32_FEATURE_CONTROL
to enable SMRR so configure IA32_FEATURE_CONTROL early on */ to enable SMRR so configure IA32_FEATURE_CONTROL early on */
static void pre_mp_smm_init(void) static void pre_mp_smm_init(void)
@ -98,6 +106,7 @@ static const struct mp_ops mp_ops = {
.pre_mp_init = pre_mp_init, .pre_mp_init = pre_mp_init,
.get_cpu_count = get_cpu_count, .get_cpu_count = get_cpu_count,
.get_smm_info = smm_info, .get_smm_info = smm_info,
.get_microcode_info = get_microcode_info,
.pre_mp_smm_init = pre_mp_smm_init, .pre_mp_smm_init = pre_mp_smm_init,
.per_cpu_smm_trigger = per_cpu_smm_trigger, .per_cpu_smm_trigger = per_cpu_smm_trigger,
.relocation_handler = smm_relocation_handler, .relocation_handler = smm_relocation_handler,
@ -106,6 +115,8 @@ static const struct mp_ops mp_ops = {
void bsp_init_and_start_aps(struct bus *cpu_bus) void bsp_init_and_start_aps(struct bus *cpu_bus)
{ {
microcode_patch = intel_microcode_find();
if (mp_init_with_smm(cpu_bus, &mp_ops)) if (mp_init_with_smm(cpu_bus, &mp_ops))
printk(BIOS_ERR, "MP initialization failure.\n"); printk(BIOS_ERR, "MP initialization failure.\n");
} }