From 2d119a3f01eee6c4e86248b17b4c9ce14ab77836 Mon Sep 17 00:00:00 2001 From: Patrick Georgi Date: Fri, 12 Jun 2015 11:04:49 +0200 Subject: [PATCH] bimgtool: initialize data header Otherwise dummy contains uninitialized data, which leads to non-reproducible builds (and a leak of 4 bytes of stack data). Change-Id: Iaaf846580ec436fdd4f0800c7576b544f50d6ae0 Signed-off-by: Patrick Georgi Reviewed-on: http://review.coreboot.org/10524 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Stefan Reinauer --- util/bimgtool/bimgtool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/util/bimgtool/bimgtool.c b/util/bimgtool/bimgtool.c index a970234ffe..505bf7d8cc 100644 --- a/util/bimgtool/bimgtool.c +++ b/util/bimgtool/bimgtool.c @@ -160,7 +160,7 @@ static const struct crc_t crc_type = { static int write_binary(FILE *out, FILE *in, struct bimg_header *hdr) { static uint8_t file_buf[MAX_RECORD_BYTES]; - struct bimg_data_header data_hdr; + struct bimg_data_header data_hdr = { 0 }; size_t n_written; data_hdr.dest_addr = hdr->entry_addr;