GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

payloads/coreinfo: Free buffer before returning 

Fixes coverity issue 1373370 - Resource leak

Change-Id: I71e0d3ae7f9152e1f89f8b3206526f0d344e0351
Signed-off-by: Martin Roth <martinroth@google.com>
Reviewed-on: https://review.coreboot.org/20876
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
This commit is contained in:
Martin Roth 2017-08-03 10:55:01 -06:00
parent 6223a200aa
commit 2d1e0eb8a7
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
payloads/coreinfo/timestamps_module.c
View File

@ -210,8 +210,10 @@ static int timestamps_module_init(void)
g_max_cursor_line = MAX(g_lines_count - 1 - LINES_SHOWN, 0); g_max_cursor_line = MAX(g_lines_count - 1 - LINES_SHOWN, 0);
g_buf = malloc(chars_count); g_buf = malloc(chars_count);
if (!g_buf) if (!g_buf) {
free(buffer);
return -3; return -3;
}
if (sanitize_buffer_for_display(buffer, buff_cur + 1, g_buf, if (sanitize_buffer_for_display(buffer, buff_cur + 1, g_buf,
chars_count, SCREEN_X) < 0) { chars_count, SCREEN_X) < 0) {