GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

baytrail: add C0 and D0 stepping decode 

The E3800 with ordering code FH8065301487717 is stepping D0, value 0x11.
Add that so the debug log shows 'D0' instead of '??'.

Also, add the C0 stepping decode to fsp_baytrail.

Change-Id: Ibec764fcf5d3f448e38831786a071f5ab6066d67
Signed-off-by: Ben Gardner <gardner.ben@gmail.com>
Reviewed-on: http://review.coreboot.org/12488
Tested-by: build bot (Jenkins)
Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
Ben Gardner 2015-11-19 16:12:21 -06:00 committed by Martin Roth
parent 42b6265035
commit 2d3d1b7eee
4 changed files with 19 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/soc/intel/baytrail/include/soc/lpc.h
View File

@ -33,6 +33,8 @@
#define RID_A_STEPPING_START 1 #define RID_A_STEPPING_START 1
#define RID_B_STEPPING_START 5 #define RID_B_STEPPING_START 5
#define RID_C_STEPPING_START 0xe #define RID_C_STEPPING_START 0xe
#define RID_D_STEPPING_START 0x11
enum baytrail_stepping { enum baytrail_stepping {
STEP_A0, STEP_A0,
STEP_A1, STEP_A1,
@ -41,6 +43,7 @@ enum baytrail_stepping {
STEP_B2, STEP_B2,
STEP_B3, STEP_B3,
STEP_C0, STEP_C0,
STEP_D0,
}; };
/* Registers behind the RCBA_BASE_ADDRESS bar. */ /* Registers behind the RCBA_BASE_ADDRESS bar. */

7
src/soc/intel/baytrail/ramstage.c
View File

@ -70,7 +70,7 @@ static inline void fill_in_msr(msr_t *msr, int idx)
} }
static const char *stepping_str[] = { static const char *stepping_str[] = {
"A0", "A1", "B0", "B1", "B2", "B3", "C0" "A0", "A1", "B0", "B1", "B2", "B3", "C0", "D0",
}; };
static void fill_in_pattrs(void) static void fill_in_pattrs(void)
@ -83,7 +83,10 @@ static void fill_in_pattrs(void)
dev = dev_find_slot(0, PCI_DEVFN(LPC_DEV, LPC_FUNC)); dev = dev_find_slot(0, PCI_DEVFN(LPC_DEV, LPC_FUNC));
attrs->revid = pci_read_config8(dev, REVID); attrs->revid = pci_read_config8(dev, REVID);
/* The revision to stepping IDs have two values per metal stepping. */ /* The revision to stepping IDs have two values per metal stepping. */
if (attrs->revid >= RID_C_STEPPING_START) { if (attrs->revid >= RID_D_STEPPING_START) {
attrs->stepping = (attrs->revid - RID_D_STEPPING_START) / 2;
attrs->stepping += STEP_D0;
} else if (attrs->revid >= RID_C_STEPPING_START) {
attrs->stepping = (attrs->revid - RID_C_STEPPING_START) / 2; attrs->stepping = (attrs->revid - RID_C_STEPPING_START) / 2;
attrs->stepping += STEP_C0; attrs->stepping += STEP_C0;
} else if (attrs->revid >= RID_B_STEPPING_START) { } else if (attrs->revid >= RID_B_STEPPING_START) {

3
src/soc/intel/fsp_baytrail/baytrail/lpc.h
View File

@ -86,6 +86,8 @@
#define RID_A_STEPPING_START 1 #define RID_A_STEPPING_START 1
#define RID_B_STEPPING_START 5 #define RID_B_STEPPING_START 5
#define RID_C_STEPPING_START 0xe #define RID_C_STEPPING_START 0xe
#define RID_D_STEPPING_START 0x11
enum baytrail_stepping { enum baytrail_stepping {
STEP_A0, STEP_A0,
STEP_A1, STEP_A1,
@ -94,6 +96,7 @@ enum baytrail_stepping {
STEP_B2, STEP_B2,
STEP_B3, STEP_B3,
STEP_C0, STEP_C0,
STEP_D0,
}; };
/* Registers behind the RCBA_BASE_ADDRESS bar. */ /* Registers behind the RCBA_BASE_ADDRESS bar. */

10
src/soc/intel/fsp_baytrail/ramstage.c
View File

@ -68,7 +68,7 @@ static inline void fill_in_msr(msr_t *msr, int idx)
} }
static const char *stepping_str[] = { static const char *stepping_str[] = {
"A0", "A1", "B0", "B1", "B2", "B3" "A0", "A1", "B0", "B1", "B2", "B3", "C0", "D0",
}; };
static void fill_in_pattrs(void) static void fill_in_pattrs(void)
@ -81,7 +81,13 @@ static void fill_in_pattrs(void)
dev = dev_find_slot(0, PCI_DEVFN(LPC_DEV, LPC_FUNC)); dev = dev_find_slot(0, PCI_DEVFN(LPC_DEV, LPC_FUNC));
attrs->revid = pci_read_config8(dev, REVID); attrs->revid = pci_read_config8(dev, REVID);
/* The revision to stepping IDs have two values per metal stepping. */ /* The revision to stepping IDs have two values per metal stepping. */
if (attrs->revid >= RID_B_STEPPING_START) { if (attrs->revid >= RID_D_STEPPING_START) {
attrs->stepping = (attrs->revid - RID_D_STEPPING_START) / 2;
attrs->stepping += STEP_D0;
} else if (attrs->revid >= RID_C_STEPPING_START) {
attrs->stepping = (attrs->revid - RID_C_STEPPING_START) / 2;
attrs->stepping += STEP_C0;
} else if (attrs->revid >= RID_B_STEPPING_START) {
attrs->stepping = (attrs->revid - RID_B_STEPPING_START) / 2; attrs->stepping = (attrs->revid - RID_B_STEPPING_START) / 2;
attrs->stepping += STEP_B0; attrs->stepping += STEP_B0;
} else { } else {