mb/google/poppy: Declare output GPIOs as pull-downs
The pull direction is used to determine the initial state of the pin. If no pull direction is specified, the pin will remain as input. Fix this. BUG=chromium:959232 Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Tested-by: Jacopo Mondi <jacopo@jmondi.org> Change-Id: I1158bc8aaa447b223e8ce25d808348e758de28c5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/36721 Reviewed-by: Patrick Georgi <pgeorgi@google.com> Reviewed-by: Furquan Shaikh <furquan@google.com> Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
parent
1804b15896
commit
2d54fc9581
|
@ -142,21 +142,21 @@ Scope (\_SB.PCI0.I2C2)
|
|||
2
|
||||
}
|
||||
/* GPIO.4 is AVDD pin for user facing camera */
|
||||
GpioIo (Exclusive, PullDefault, 0x0000, 0x0000,
|
||||
GpioIo (Exclusive, PullDown, 0x0000, 0x0000,
|
||||
IoRestrictionOutputOnly, "\\_SB.PCI0.I2C2.PMIC",
|
||||
0x00, ResourceConsumer,,)
|
||||
{
|
||||
4
|
||||
}
|
||||
/* GPIO.5 is XSHUTDOWN pin for user facing camera */
|
||||
GpioIo (Exclusive, PullDefault, 0x0000, 0x0000,
|
||||
GpioIo (Exclusive, PullDown, 0x0000, 0x0000,
|
||||
IoRestrictionOutputOnly, "\\_SB.PCI0.I2C2.PMIC",
|
||||
0x00, ResourceConsumer,,)
|
||||
{
|
||||
5
|
||||
}
|
||||
/* GPIO.9 is XSHUTDOWN pin for world facing camera */
|
||||
GpioIo (Exclusive, PullDefault, 0x0000, 0x0000,
|
||||
GpioIo (Exclusive, PullDown, 0x0000, 0x0000,
|
||||
IoRestrictionOutputOnly, "\\_SB.PCI0.I2C2.PMIC",
|
||||
0x00, ResourceConsumer,,)
|
||||
{
|
||||
|
@ -188,7 +188,7 @@ Scope (\_SB.PCI0.I2C2)
|
|||
GPO2, 1,
|
||||
Connection
|
||||
(
|
||||
GpioIo (Exclusive, PullDefault, 0x0000, 0x0000,
|
||||
GpioIo (Exclusive, PullDown, 0x0000, 0x0000,
|
||||
IoRestrictionOutputOnly,
|
||||
"\\_SB.PCI0.I2C2.PMIC", 0x00,
|
||||
ResourceConsumer,,)
|
||||
|
@ -199,7 +199,7 @@ Scope (\_SB.PCI0.I2C2)
|
|||
GRST, 1,
|
||||
Connection
|
||||
(
|
||||
GpioIo (Exclusive, PullDefault, 0x0000, 0x0000,
|
||||
GpioIo (Exclusive, PullDown, 0x0000, 0x0000,
|
||||
IoRestrictionOutputOnly,
|
||||
"\\_SB.PCI0.I2C2.PMIC", 0x00,
|
||||
ResourceConsumer,,)
|
||||
|
@ -210,7 +210,7 @@ Scope (\_SB.PCI0.I2C2)
|
|||
GPO4, 1,
|
||||
Connection
|
||||
(
|
||||
GpioIo (Exclusive, PullDefault, 0x0000, 0x0000,
|
||||
GpioIo (Exclusive, PullDown, 0x0000, 0x0000,
|
||||
IoRestrictionOutputOnly,
|
||||
"\\_SB.PCI0.I2C2.PMIC", 0x00,
|
||||
ResourceConsumer,,)
|
||||
|
|
Loading…
Reference in New Issue