src/ec,mainboard: Move weak smbios_system_sku() override inwards

Internalise smbios_system_sku() strong symbol inwards in the ec_skuid.c
implementation and simply wrap a call to:
google_chromeec_smbios_system_sku().

BUG=b:150735116
BRANCH=none
TEST=none

Change-Id: I05ebfc8126c0fb176ca52c307c658f50611ab6ab
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/39146
Reviewed-by: Karthik Ramasubramanian <kramasub@google.com>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Edward O'Callaghan 2020-02-27 15:27:31 +11:00 committed by Edward O'Callaghan
parent abd02cc1ca
commit 2d7bb7e141
6 changed files with 6 additions and 43 deletions

View File

@ -11,6 +11,7 @@
#include <ec/google/chromeec/ec.h>
#include <console/console.h>
#include <string.h>
#include <smbios.h>
#define SKU_UNKNOWN 0xFFFFFFFF
@ -34,3 +35,8 @@ const char *google_chromeec_smbios_system_sku(void)
snprintf(sku_str, sizeof(sku_str), "sku%u", sku_id);
return sku_str;
}
const char *smbios_system_sku(void)
{
return google_chromeec_smbios_system_sku();
}

View File

@ -12,11 +12,6 @@
#include <smbios.h>
#include <string.h>
const char *smbios_system_sku(void)
{
return google_chromeec_smbios_system_sku();
}
const char *smbios_mainboard_manufacturer(void)
{
static char oem_name[32];

View File

@ -21,11 +21,6 @@
#include <string.h>
#include <stdint.h>
const char *smbios_system_sku(void)
{
return google_chromeec_smbios_system_sku();
}
const char *smbios_mainboard_manufacturer(void)
{
static char oem_name[32];

View File

@ -5,7 +5,6 @@ romstage-$(CONFIG_CHROMEOS) += chromeos.c
ramstage-$(CONFIG_CHROMEOS) += chromeos.c
ramstage-y += ec.c
ramstage-y += mainboard_misc.c
ramstage-y += mainboard.c
verstage-$(CONFIG_CHROMEOS) += chromeos.c

View File

@ -1,27 +0,0 @@
/*
* This file is part of the coreboot project.
*
* Copyright 2019 Intel Corp.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
#include <baseboard/variants.h>
#include <boardid.h>
#include <console/console.h>
#include <ec/google/chromeec/ec.h>
#include <ec/ec.h>
#include <smbios.h>
#include <string.h>
const char *smbios_system_sku(void)
{
return google_chromeec_smbios_system_sku();
}

View File

@ -17,11 +17,6 @@
#include <vendorcode/google/chromeos/chromeos.h>
#include <variant/gpio.h>
const char *smbios_system_sku(void)
{
return google_chromeec_smbios_system_sku();
}
static void mainboard_init(struct device *dev)
{
mainboard_ec_init();