From 2e0cf14e144593f8b364f8741f7196d829f3b427 Mon Sep 17 00:00:00 2001 From: Alexandru Gagniuc Date: Sun, 28 Dec 2014 20:38:32 -0600 Subject: [PATCH] northbridge/amd/pi/northbridge.c: Remove superfluous logic operand The "((1ull << (sizeof(modules) * 8)) - 1)" statement evaluates to 0xffffffff, but there's no need to AND with that value, as 'modules' is already 32-bit. The '&&' is most likely a typo, which meant bitwise and, as indicated by the structure of thus operation. Remove this superfluous statement. This also fixes a clang warning. Change-Id: Ie55bd9f8b0ec5fd41e440f56dcedd40c830bf826 Signed-off-by: Alexandru Gagniuc Reviewed-on: http://review.coreboot.org/7965 Reviewed-by: Edward O'Callaghan Tested-by: build bot (Jenkins) --- src/northbridge/amd/pi/00730F01/northbridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/northbridge/amd/pi/00730F01/northbridge.c b/src/northbridge/amd/pi/00730F01/northbridge.c index c8f938b5ef..ca8fa2738b 100644 --- a/src/northbridge/amd/pi/00730F01/northbridge.c +++ b/src/northbridge/amd/pi/00730F01/northbridge.c @@ -901,7 +901,7 @@ static u32 cpu_bus_scan(device_t dev, u32 max) printk(BIOS_SPEW, "MullinsPI Debug: Grabbing the AMD Topology Information.\n"); AmdGetValue(AMD_GLOBAL_USER_OPTIONS, (VOID**)&options, sizeof(options)); AmdGetValue(AMD_GLOBAL_NUM_MODULES, &modules_ptr, sizeof(modules)); - modules = (*(u32*)modules_ptr) && ((1ull << (sizeof(modules) * 8)) - 1); + modules = *(u32*)modules_ptr; ASSERT(modules > 0); ASSERT(options); ioapic_count = (int)options->CfgPlatNumIoApics;