From 2e31ea05bb2c88913310d20a9baaa83e8934da52 Mon Sep 17 00:00:00 2001 From: Jacob Garber Date: Tue, 2 Jul 2019 17:50:59 -0600 Subject: [PATCH] util/cbfstool: Close file on error Prevents a resource leak. Change-Id: I032227228c8e37e989960ad6292ded39b81835a9 Signed-off-by: Jacob Garber Found-by: Coverity CID 1383919 Reviewed-on: https://review.coreboot.org/c/coreboot/+/33992 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi --- util/cbfstool/partitioned_file.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/util/cbfstool/partitioned_file.c b/util/cbfstool/partitioned_file.c index 9abd32aab6..a2d9ddfee2 100644 --- a/util/cbfstool/partitioned_file.c +++ b/util/cbfstool/partitioned_file.c @@ -197,8 +197,10 @@ partitioned_file_t *partitioned_file_reopen(const char *filename, const struct fmap_area *fmap_fmap_entry = fmap_find_area(file->fmap, SECTION_NAME_FMAP); - if (!fmap_fmap_entry) + if (!fmap_fmap_entry) { + partitioned_file_close(file); return NULL; + } if ((long)fmap_fmap_entry->offset != fmap_region_offset) { ERROR("FMAP's '%s' section doesn't point back to FMAP start (did something corrupt this file?)\n",