GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/common/include/espi: generalize IO/MMIO decode range macros 

Sabrina has more eSPI decode ranges than Picasso or Cezanne. Those
registers are however not in one block where it's easy to calculate the
addresses of a register from the index of the decode range. Within one
group of decode range registers it's still easy to calculate the
register address, so move the base address from within the macro to the
instantiation of the macro as a preparation for adding the support for
the additional ranges.

TEST=Timeless build results in identical binary for Mandolin

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Id309d955fa3558d660db37a2075240f938361e83
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64052
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
This commit is contained in:
Felix Held 2022-05-04 17:34:16 +02:00
parent da4e1d7806
commit 2e4b95da88
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/soc/amd/common/block/include/amdblocks/espi.h
View File

@ -25,10 +25,10 @@
#define ESPI_MMIO_SIZE_REG0 0x60 #define ESPI_MMIO_SIZE_REG0 0x60
#define ESPI_MMIO_SIZE_REG1 0x64 #define ESPI_MMIO_SIZE_REG1 0x64
#define ESPI_IO_RANGE_BASE(range) (ESPI_IO_BASE_REG0 + ((range) & 3) * 2) #define ESPI_IO_RANGE_BASE_REG(base, range) ((base) + ((range) & 3) * 2)
#define ESPI_IO_RANGE_SIZE(range) (ESPI_IO_SIZE0 + ((range) & 3)) #define ESPI_IO_RANGE_SIZE_REG(base, range) ((base) + ((range) & 3))
#define ESPI_MMIO_RANGE_BASE(range) (ESPI_MMIO_BASE_REG0 + ((range) & 3) * 4) #define ESPI_MMIO_RANGE_BASE_REG(base, range) ((base) + ((range) & 3) * 4)
#define ESPI_MMIO_RANGE_SIZE(range) (ESPI_MMIO_SIZE_REG0 + ((range) & 3) * 2) #define ESPI_MMIO_RANGE_SIZE_REG(base, range) ((base) + ((range) & 3) * 2)
#define ESPI_GENERIC_IO_WIN_COUNT 4 #define ESPI_GENERIC_IO_WIN_COUNT 4
#define ESPI_GENERIC_IO_MAX_WIN_SIZE 0x100 #define ESPI_GENERIC_IO_MAX_WIN_SIZE 0x100

8
src/soc/amd/common/block/lpc/espi_util.c
View File

@ -72,22 +72,22 @@ static inline uint32_t espi_decode_mmio_range_en_bit(unsigned int idx)
static inline unsigned int espi_io_range_base_reg(unsigned int idx) static inline unsigned int espi_io_range_base_reg(unsigned int idx)
{ {
return ESPI_IO_RANGE_BASE(idx); return ESPI_IO_RANGE_BASE_REG(ESPI_IO_BASE_REG0, idx);
} }
static inline unsigned int espi_io_range_size_reg(unsigned int idx) static inline unsigned int espi_io_range_size_reg(unsigned int idx)
{ {
return ESPI_IO_RANGE_SIZE(idx); return ESPI_IO_RANGE_SIZE_REG(ESPI_IO_SIZE0, idx);
} }
static inline unsigned int espi_mmio_range_base_reg(unsigned int idx) static inline unsigned int espi_mmio_range_base_reg(unsigned int idx)
{ {
return ESPI_MMIO_RANGE_BASE(idx); return ESPI_MMIO_RANGE_BASE_REG(ESPI_MMIO_BASE_REG0, idx);
} }
static inline unsigned int espi_mmio_range_size_reg(unsigned int idx) static inline unsigned int espi_mmio_range_size_reg(unsigned int idx)
{ {
return ESPI_MMIO_RANGE_SIZE(idx); return ESPI_MMIO_RANGE_SIZE_REG(ESPI_MMIO_SIZE_REG0, idx);
} }
static void espi_enable_decode(uint32_t decode_en) static void espi_enable_decode(uint32_t decode_en)