GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/amd/*/smihandler: use size_t and unsigned int 

signed int should only be used when we need negative values and in those
cases the value shouldn't became negative.

Change-Id: Iefac021260ff363c76bf5cd3fe3619ea1dbabdba
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50486
Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Felix Held 2021-02-10 16:48:23 +01:00
parent a2db88eb5a
commit 2e97897ea3
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/soc/amd/picasso/smihandler.c
View File

@ -18,6 +18,7 @@
#include <amdblocks/smm.h> #include <amdblocks/smm.h>
#include <elog.h> #include <elog.h>
#include <soc/smu.h> #include <soc/smu.h>
#include <types.h>
/* bits in smm_io_trap */ /* bits in smm_io_trap */
#define SMM_IO_TRAP_PORT_OFFSET 16 #define SMM_IO_TRAP_PORT_OFFSET 16
@ -33,7 +34,7 @@ static inline u16 get_io_address(u32 info)
static void *find_save_state(int cmd) static void *find_save_state(int cmd)
{ {
int core; unsigned int core;
amd64_smm_state_save_area_t *state; amd64_smm_state_save_area_t *state;
u32 smm_io_trap; u32 smm_io_trap;
u8 reg_al; u8 reg_al;
@ -225,7 +226,7 @@ static const struct smi_sources_t smi_sources[] = {
void *get_smi_source_handler(int source) void *get_smi_source_handler(int source)
{ {
int i; size_t i;
for (i = 0 ; i < ARRAY_SIZE(smi_sources) ; i++) for (i = 0 ; i < ARRAY_SIZE(smi_sources) ; i++)
if (smi_sources[i].type == source) if (smi_sources[i].type == source)

5
src/soc/amd/stoneyridge/smihandler.c
View File

@ -16,6 +16,7 @@
#include <amdblocks/smi.h> #include <amdblocks/smi.h>
#include <amdblocks/smm.h> #include <amdblocks/smm.h>
#include <elog.h> #include <elog.h>
#include <types.h>
/* bits in smm_io_trap */ /* bits in smm_io_trap */
#define SMM_IO_TRAP_PORT_OFFSET 16 #define SMM_IO_TRAP_PORT_OFFSET 16
@ -31,7 +32,7 @@ static inline u16 get_io_address(u32 info)
static void *find_save_state(int cmd) static void *find_save_state(int cmd)
{ {
int core; unsigned int core;
amd64_smm_state_save_area_t *state; amd64_smm_state_save_area_t *state;
u32 smm_io_trap; u32 smm_io_trap;
u8 reg_al; u8 reg_al;
@ -220,7 +221,7 @@ static const struct smi_sources_t smi_sources[] = {
void *get_smi_source_handler(int source) void *get_smi_source_handler(int source)
{ {
int i; size_t i;
for (i = 0 ; i < ARRAY_SIZE(smi_sources) ; i++) for (i = 0 ; i < ARRAY_SIZE(smi_sources) ; i++)
if (smi_sources[i].type == source) if (smi_sources[i].type == source)