From 2f5025efeda354cf3180059ade8e35201884bea3 Mon Sep 17 00:00:00 2001 From: Arthur Heymans Date: Wed, 26 Oct 2022 08:19:46 +0200 Subject: [PATCH] Revert "soc/intel/systemagent.c: Fix memory type reporting" This reverts commit 9c2f3cc9d9b3b3b7cfe1e62a70ea3061ca6c15ac. This broke the smihandler for no clear reason on some platforms. Change-Id: I72da99c019241b627ce8b543937364a53a5fe97b Signed-off-by: Arthur Heymans Reviewed-on: https://review.coreboot.org/c/coreboot/+/68879 Tested-by: build bot (Jenkins) Reviewed-by: Werner Zeh Reviewed-by: Sean Rhodes --- src/soc/intel/common/block/systemagent/systemagent.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/soc/intel/common/block/systemagent/systemagent.c b/src/soc/intel/common/block/systemagent/systemagent.c index ad60159f06..e74c11856b 100644 --- a/src/soc/intel/common/block/systemagent/systemagent.c +++ b/src/soc/intel/common/block/systemagent/systemagent.c @@ -201,8 +201,11 @@ static void sa_add_dram_resources(struct device *dev, int *resource_count) sa_get_mem_map(dev, &sa_map_values[0]); - /* top_of_ram -> TOLUD */ - reserved_ram_from_to(dev, index++, top_of_ram, sa_map_values[SA_TOLUD_REG]); + /* + * top_of_ram -> TOLUD: This contains TSEG which needs to be uncacheable + * for proper operation of the smihandler. + */ + mmio_from_to(dev, index++, top_of_ram, sa_map_values[SA_TOLUD_REG]); /* 4GiB -> TOUUD */ upper_ram_end(dev, index++, sa_map_values[SA_TOUUD_REG]);