From 2f8f1b44021aeb8c38a2fb2d0880dd93a00526a7 Mon Sep 17 00:00:00 2001 From: Tim Wawrzynczak Date: Mon, 27 Jun 2022 11:10:26 -0600 Subject: [PATCH] soc/intel/elkhartlake: Fix PMC read_resources callback The `limit` field for the PMC fixed BAR was incorrectly set to the `base + size + 1`, where it should be `base + size - 1`, to correctly tell the allocator the limit. Signed-off-by: Tim Wawrzynczak Change-Id: Ib2d8c7ffe87fdd970f3172bb4e6b2c9386859ab3 Reviewed-on: https://review.coreboot.org/c/coreboot/+/65460 Reviewed-by: Angel Pons Reviewed-by: Werner Zeh Tested-by: build bot (Jenkins) --- src/soc/intel/elkhartlake/pmc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/soc/intel/elkhartlake/pmc.c b/src/soc/intel/elkhartlake/pmc.c index 223e17070f..e556ac81f8 100644 --- a/src/soc/intel/elkhartlake/pmc.c +++ b/src/soc/intel/elkhartlake/pmc.c @@ -76,7 +76,7 @@ static void soc_pmc_read_resources(struct device *dev) res = new_resource(dev, 1); res->base = (resource_t)ACPI_BASE_ADDRESS; res->size = (resource_t)ACPI_BASE_SIZE; - res->limit = res->base + res->size + 1; + res->limit = res->base + res->size - 1; res->flags = IORESOURCE_IO | IORESOURCE_ASSIGNED | IORESOURCE_FIXED; }