GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/amd/birman: Don't select the console UART, default to y 

Things with prompts should not use selects, but should instead default
to y. If there's a reason they need to be selected, they should be able
to be hidden when they're selected.

This isn't one of those cases where a select is needed, so set the
default to y instead.

Signed-off-by: Martin Roth <gaumless@gmail.com>
Change-Id: If6de339c3a1ceb3cd71008402bba49b5efc4af3f
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75131
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Fred Reitberger <reitbergerfred@gmail.com>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
This commit is contained in:
Martin Roth 2023-05-10 13:32:29 -06:00 committed by Martin L Roth
parent dd4fa8e603
commit 2fca0261f1
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/mainboard/amd/birman/Kconfig
View File

@ -7,7 +7,6 @@ config BOARD_SPECIFIC_OPTIONS
select BOARD_ROMSIZE_KB_16384 # Birman actually has a 32MiB ROM select BOARD_ROMSIZE_KB_16384 # Birman actually has a 32MiB ROM
select EC_ACPI select EC_ACPI
select SOC_AMD_COMMON_BLOCK_USE_ESPI if !SOC_AMD_COMMON_BLOCK_SIMNOW_BUILD select SOC_AMD_COMMON_BLOCK_USE_ESPI if !SOC_AMD_COMMON_BLOCK_SIMNOW_BUILD
select AMD_SOC_CONSOLE_UART if !SOC_AMD_COMMON_BLOCK_SIMNOW_BUILD
select DRIVERS_PCIE_RTD3_DEVICE select DRIVERS_PCIE_RTD3_DEVICE
select MAINBOARD_HAS_CHROMEOS select MAINBOARD_HAS_CHROMEOS
select PCIEXP_ASPM select PCIEXP_ASPM
@ -48,6 +47,9 @@ config BIRMAN_MCHP_SIG_FILE
The first 4 bytes form a pointer (with CRC) to where the EC firmware The first 4 bytes form a pointer (with CRC) to where the EC firmware
is located is located
config AMD_SOC_CONSOLE_UART
default y if !SOC_AMD_COMMON_BLOCK_SIMNOW_BUILD
config BIRMAN_MCHP_FW_FILE config BIRMAN_MCHP_FW_FILE
string "Microchip EC firmware file" string "Microchip EC firmware file"
depends on BIRMAN_HAVE_MCHP_FW depends on BIRMAN_HAVE_MCHP_FW