From 3032d7677883eb726d14fcd85efae7a7c068259a Mon Sep 17 00:00:00 2001 From: Aamir Bohra Date: Wed, 21 Nov 2018 12:31:54 +0530 Subject: [PATCH] mb/intel/icelake_rvp: Add support for ALPS touchpad BUG:none TEST:Verify cursor response and button clicks Change-Id: I4085b70560e2840c71b989348f56ca907e7cea4b Signed-off-by: Aamir Bohra Reviewed-on: https://review.coreboot.org/c/29777 Reviewed-by: Subrata Banik Reviewed-by: Shelley Chen Tested-by: build bot (Jenkins) --- .../intel/icelake_rvp/variants/icl_u/devicetree.cb | 10 +++++++++- .../intel/icelake_rvp/variants/icl_y/devicetree.cb | 10 +++++++++- 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/src/mainboard/intel/icelake_rvp/variants/icl_u/devicetree.cb b/src/mainboard/intel/icelake_rvp/variants/icl_u/devicetree.cb index a57d91afbe..603be42d91 100644 --- a/src/mainboard/intel/icelake_rvp/variants/icl_u/devicetree.cb +++ b/src/mainboard/intel/icelake_rvp/variants/icl_u/devicetree.cb @@ -106,7 +106,15 @@ chip soc/intel/icelake device pci 14.3 on end # CNVi wifi end device pci 14.5 on end # SDCard - device pci 15.0 on end # I2C #0 + device pci 15.0 on + chip drivers/i2c/hid + register "generic.hid" = ""ALPS0000"" + register "generic.desc" = ""Touchpad"" + register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C8_IRQ)" + register "hid_desc_reg_offset" = "0x20" + device i2c 2c on end + end + end # I2C 0 device pci 15.1 on end # I2C #1 device pci 15.2 off end # I2C #2 device pci 15.3 on end # I2C #3 diff --git a/src/mainboard/intel/icelake_rvp/variants/icl_y/devicetree.cb b/src/mainboard/intel/icelake_rvp/variants/icl_y/devicetree.cb index f8fbfb4c29..a1e64ee7a6 100644 --- a/src/mainboard/intel/icelake_rvp/variants/icl_y/devicetree.cb +++ b/src/mainboard/intel/icelake_rvp/variants/icl_y/devicetree.cb @@ -90,7 +90,15 @@ chip soc/intel/icelake device pci 14.3 on end # CNVi wifi end device pci 14.5 on end # SDCard - device pci 15.0 on end # I2C 0 + device pci 15.0 on + chip drivers/i2c/hid + register "generic.hid" = ""ALPS0000"" + register "generic.desc" = ""Touchpad"" + register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C8_IRQ)" + register "hid_desc_reg_offset" = "0x20" + device i2c 2c on end + end + end # I2C 0 device pci 15.1 on end # I2C #1 device pci 15.2 off end # I2C #2 device pci 15.3 on end # I2C #3