From 3053a021b62af324f11553fc9c50ed2d2b7eb7dc Mon Sep 17 00:00:00 2001 From: Robert Chen Date: Thu, 23 Feb 2023 04:13:04 -0500 Subject: [PATCH] Revert "mb/google/brya/var/lisbon: Update gpio table" This reverts commit 0e0f9e51c4c4f190cbe7ef5bffa138601c644d3c. Reason for revert: PLTRST only keeps 18xms and it's too short for eMMC disk fully reset. Change-Id: I13b93747bdb4d39de1ffcfdc020648871fa6e048 Signed-off-by: Robert Chen Reviewed-on: https://review.coreboot.org/c/coreboot/+/73203 Reviewed-by: Kevin Chiu Tested-by: build bot (Jenkins) Reviewed-by: Nick Vaccaro --- src/mainboard/google/brya/variants/lisbon/gpio.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mainboard/google/brya/variants/lisbon/gpio.c b/src/mainboard/google/brya/variants/lisbon/gpio.c index 443d59c607..1dfef5ceb0 100644 --- a/src/mainboard/google/brya/variants/lisbon/gpio.c +++ b/src/mainboard/google/brya/variants/lisbon/gpio.c @@ -25,7 +25,7 @@ static const struct pad_config override_gpio_table[] = { /* B2 : VRALERT# ==> M2_SSD_PLA_L */ PAD_NC(GPP_B2, NONE), /* B3 : PROC_GP2 ==> EMMC_PERST_L */ - PAD_CFG_GPO_LOCK(GPP_B3, 1, LOCK_CONFIG), + PAD_CFG_GPO(GPP_B3, 1, DEEP), /* B7 : ISH_12C1_SDA ==> PCH_I2C_MISCB_SDA */ PAD_CFG_NF_LOCK(GPP_B7, NONE, NF2, LOCK_CONFIG), /* B8 : ISH_I2C1_SCL ==> PCH_I2C_MISCB_SCL */ @@ -91,6 +91,8 @@ static const struct pad_config early_gpio_table[] = { PAD_CFG_GPI_APIC(GPP_A13, NONE, PLTRST, LEVEL, INVERT), /* A21 : DDPC_CTRCLK ==> EN_PP3300_EMMC */ PAD_CFG_GPO(GPP_A21, 1, DEEP), + /* B3 : PROC_GP2 ==> EMMC_PERST_L */ + PAD_CFG_GPO(GPP_B3, 0, DEEP), /* B4 : PROC_GP3 ==> SSD_PERST_L */ PAD_CFG_GPO(GPP_B4, 0, DEEP), /* E15 : RSVD_TP ==> PCH_WP_OD */ @@ -134,6 +136,8 @@ static const struct pad_config early_gpio_table[] = { }; static const struct pad_config romstage_gpio_table[] = { + /* B3 : PROC_GP2 ==> EMMC_PERST_L */ + PAD_CFG_GPO(GPP_B3, 1, DEEP), /* B4 : PROC_GP3 ==> SSD_PERST_L */ PAD_CFG_GPO(GPP_B4, 1, DEEP), };