GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

lib: Check for non-existent DIMMs in check_if_dimm_changed 

Treat dimm addr_map 0 non-existent. addr_map default is 0, we don't set
it if Hw is not present. Also change the test case default to avoid 0.
SODIMM SMbus address 0x50 to 0x53 is commonly used.

BUG=b:213964936
BRANCH=firmware-brya-14505.B
TEST=emerge-brya coreboot chromeos-bootimage
The MRC training does not be performed again after rebooting.

Signed-off-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Change-Id: I2ada0109eb0805174cb85d4ce373e2a3ab7dbcac
Reviewed-on: https://review.coreboot.org/c/coreboot/+/63628
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Frank Wu <frank_wu@compal.corp-partner.google.com>
Reviewed-by: Lean Sheng Tan <sheng.tan@9elements.com>
Reviewed-by: Subrata Banik <subratabanik@google.com>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
This commit is contained in:
Eric Lai 2022-04-14 15:22:52 +08:00 committed by Subrata Banik
parent d083317fae
commit 3067701108
2 changed files with 14 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/lib/spd_cache.c
View File

@ -155,6 +155,10 @@ bool check_if_dimm_changed(u8 *spd_cache, struct spd_block *blk)
bool dimm_changed = false; bool dimm_changed = false;
/* Check if the dimm is the same with last system boot. */ /* Check if the dimm is the same with last system boot. */
for (i = 0; i < SC_SPD_NUMS && !dimm_changed; i++) { for (i = 0; i < SC_SPD_NUMS && !dimm_changed; i++) {
if (blk->addr_map[i] == 0) {
printk(BIOS_NOTICE, "SPD_CACHE: DIMM%d does not exist\n", i);
continue;
}
/* Return true if any error happened here. */ /* Return true if any error happened here. */
if (get_spd_sn(blk->addr_map[i], &sn) == CB_ERR) if (get_spd_sn(blk->addr_map[i], &sn) == CB_ERR)
return true; return true;

15
tests/lib/spd_cache-test.c
View File

@ -146,7 +146,8 @@ __attribute__((unused)) static void test_check_if_dimm_changed_not_changed(void
{ {
uint8_t *spd_cache; uint8_t *spd_cache;
size_t spd_cache_sz; size_t spd_cache_sz;
struct spd_block blk = {.addr_map = {0}, .spd_array = {0}, .len = 0}; struct spd_block blk = {.addr_map = {0x50, 0x51, 0x52, 0x53},
.spd_array = {0}, .len = 0};
assert_int_equal(CB_SUCCESS, load_spd_cache(&spd_cache, &spd_cache_sz)); assert_int_equal(CB_SUCCESS, load_spd_cache(&spd_cache, &spd_cache_sz));
fill_spd_cache_ddr4(spd_cache, spd_cache_sz); fill_spd_cache_ddr4(spd_cache, spd_cache_sz);
@ -162,7 +163,8 @@ __attribute__((unused)) static void test_check_if_dimm_changed_sn_error(void **s
{ {
uint8_t *spd_cache; uint8_t *spd_cache;
size_t spd_cache_sz; size_t spd_cache_sz;
struct spd_block blk = {.addr_map = {0}, .spd_array = {0}, .len = 0}; struct spd_block blk = {.addr_map = {0x50, 0x51, 0x52, 0x53},
.spd_array = {0}, .len = 0};
assert_int_equal(CB_SUCCESS, load_spd_cache(&spd_cache, &spd_cache_sz)); assert_int_equal(CB_SUCCESS, load_spd_cache(&spd_cache, &spd_cache_sz));
fill_spd_cache_ddr4(spd_cache, spd_cache_sz); fill_spd_cache_ddr4(spd_cache, spd_cache_sz);
@ -177,7 +179,8 @@ __attribute__((unused)) static void test_check_if_dimm_changed_sodimm_lost(void
{ {
uint8_t *spd_cache; uint8_t *spd_cache;
size_t spd_cache_sz; size_t spd_cache_sz;
struct spd_block blk = {.addr_map = {0}, .spd_array = {0}, .len = 0}; struct spd_block blk = {.addr_map = {0x50, 0x51, 0x52, 0x53},
.spd_array = {0}, .len = 0};
assert_int_equal(CB_SUCCESS, load_spd_cache(&spd_cache, &spd_cache_sz)); assert_int_equal(CB_SUCCESS, load_spd_cache(&spd_cache, &spd_cache_sz));
fill_spd_cache_ddr4(spd_cache, spd_cache_sz); fill_spd_cache_ddr4(spd_cache, spd_cache_sz);
@ -194,7 +197,8 @@ __attribute__((unused)) static void test_check_if_dimm_changed_new_sodimm(void *
{ {
uint8_t *spd_cache; uint8_t *spd_cache;
size_t spd_cache_sz; size_t spd_cache_sz;
struct spd_block blk = {.addr_map = {0}, .spd_array = {0}, .len = 0}; struct spd_block blk = {.addr_map = {0x50, 0x51, 0x52, 0x53},
.spd_array = {0}, .len = 0};
assert_int_equal(CB_SUCCESS, load_spd_cache(&spd_cache, &spd_cache_sz)); assert_int_equal(CB_SUCCESS, load_spd_cache(&spd_cache, &spd_cache_sz));
fill_spd_cache_ddr4(spd_cache, spd_cache_sz); fill_spd_cache_ddr4(spd_cache, spd_cache_sz);
@ -212,7 +216,8 @@ __attribute__((unused)) static void test_check_if_dimm_changed_sn_changed(void *
{ {
uint8_t *spd_cache; uint8_t *spd_cache;
size_t spd_cache_sz; size_t spd_cache_sz;
struct spd_block blk = {.addr_map = {0}, .spd_array = {0}, .len = 0}; struct spd_block blk = {.addr_map = {0x50, 0x51, 0x52, 0x53},
.spd_array = {0}, .len = 0};
assert_int_equal(CB_SUCCESS, load_spd_cache(&spd_cache, &spd_cache_sz)); assert_int_equal(CB_SUCCESS, load_spd_cache(&spd_cache, &spd_cache_sz));
fill_spd_cache_ddr4(spd_cache, spd_cache_sz); fill_spd_cache_ddr4(spd_cache, spd_cache_sz);