GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

acpigen: Make gpio set/get arguments const 

The 'struct acpi_gpio' arguments passed to acpigen functions are
not modified so they can be made const, which allows drivers to
also use a const pointer.

Signed-off-by: Duncan Laurie <dlaurie@google.com>
Change-Id: I59e9c19e7bfdca275230776497767ddc7f6c52db
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46257
Reviewed-by: Furquan Shaikh <furquan@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Duncan Laurie 2020-10-09 04:48:53 +00:00 committed by Duncan Laurie
parent 36858208e6
commit 30c3f91d33
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/acpi/acpigen.c
View File

@ -1865,7 +1865,7 @@ int __weak acpigen_soc_clear_tx_gpio(unsigned int gpio_num)
* *
* Returns 0 on success and -1 on error. * Returns 0 on success and -1 on error.
*/ */
int acpigen_enable_tx_gpio(struct acpi_gpio *gpio) int acpigen_enable_tx_gpio(const struct acpi_gpio *gpio)
{ {
if (gpio->active_low) if (gpio->active_low)
return acpigen_soc_clear_tx_gpio(gpio->pins[0]); return acpigen_soc_clear_tx_gpio(gpio->pins[0]);
@ -1873,7 +1873,7 @@ int acpigen_enable_tx_gpio(struct acpi_gpio *gpio)
return acpigen_soc_set_tx_gpio(gpio->pins[0]); return acpigen_soc_set_tx_gpio(gpio->pins[0]);
} }
int acpigen_disable_tx_gpio(struct acpi_gpio *gpio) int acpigen_disable_tx_gpio(const struct acpi_gpio *gpio)
{ {
if (gpio->active_low) if (gpio->active_low)
return acpigen_soc_set_tx_gpio(gpio->pins[0]); return acpigen_soc_set_tx_gpio(gpio->pins[0]);
@ -1881,7 +1881,7 @@ int acpigen_disable_tx_gpio(struct acpi_gpio *gpio)
return acpigen_soc_clear_tx_gpio(gpio->pins[0]); return acpigen_soc_clear_tx_gpio(gpio->pins[0]);
} }
void acpigen_get_rx_gpio(struct acpi_gpio *gpio) void acpigen_get_rx_gpio(const struct acpi_gpio *gpio)
{ {
acpigen_soc_read_rx_gpio(gpio->pins[0]); acpigen_soc_read_rx_gpio(gpio->pins[0]);
@ -1889,7 +1889,7 @@ void acpigen_get_rx_gpio(struct acpi_gpio *gpio)
acpigen_write_xor(LOCAL0_OP, 1, LOCAL0_OP); acpigen_write_xor(LOCAL0_OP, 1, LOCAL0_OP);
} }
void acpigen_get_tx_gpio(struct acpi_gpio *gpio) void acpigen_get_tx_gpio(const struct acpi_gpio *gpio)
{ {
acpigen_soc_get_tx_gpio(gpio->pins[0]); acpigen_soc_get_tx_gpio(gpio->pins[0]);

8
src/include/acpi/acpigen.h
View File

@ -499,8 +499,8 @@ int acpigen_soc_clear_tx_gpio(unsigned int gpio_num);
* *
* Returns 0 on success and -1 on error. * Returns 0 on success and -1 on error.
*/ */
int acpigen_enable_tx_gpio(struct acpi_gpio *gpio); int acpigen_enable_tx_gpio(const struct acpi_gpio *gpio);
int acpigen_disable_tx_gpio(struct acpi_gpio *gpio); int acpigen_disable_tx_gpio(const struct acpi_gpio *gpio);
/* /*
* Helper function for getting a RX GPIO value based on the GPIO polarity. * Helper function for getting a RX GPIO value based on the GPIO polarity.
@ -508,7 +508,7 @@ int acpigen_disable_tx_gpio(struct acpi_gpio *gpio);
* This function ends up calling acpigen_soc_get_rx_gpio to make callbacks * This function ends up calling acpigen_soc_get_rx_gpio to make callbacks
* into SoC acpigen code * into SoC acpigen code
*/ */
void acpigen_get_rx_gpio(struct acpi_gpio *gpio); void acpigen_get_rx_gpio(const struct acpi_gpio *gpio);
/* /*
* Helper function for getting a TX GPIO value based on the GPIO polarity. * Helper function for getting a TX GPIO value based on the GPIO polarity.
@ -516,7 +516,7 @@ void acpigen_get_rx_gpio(struct acpi_gpio *gpio);
* This function ends up calling acpigen_soc_get_tx_gpio to make callbacks * This function ends up calling acpigen_soc_get_tx_gpio to make callbacks
* into SoC acpigen code * into SoC acpigen code
*/ */
void acpigen_get_tx_gpio(struct acpi_gpio *gpio); void acpigen_get_tx_gpio(const struct acpi_gpio *gpio);
/* refer to ACPI 6.4.3.5.3 Word Address Space Descriptor section for details */ /* refer to ACPI 6.4.3.5.3 Word Address Space Descriptor section for details */
void acpigen_resource_word(u16 res_type, u16 gen_flags, u16 type_flags, u16 gran, void acpigen_resource_word(u16 res_type, u16 gen_flags, u16 type_flags, u16 gran,