GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/guybrush: Remove WWAN_DISABLE GPIO 

In-band controls work to enable/disable the WWAN module. Hence
WWAN_DISABLE_GPIO is not critical and can be marked as not connected.

BUG=b:188415287
TEST=Build and boot to OS in Guybrush. Ensure that the WWAN module is
enumerated on boot and reboot.

Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Change-Id: I7fefba3de9c749971911b21ed4712e950cef5a6a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/58599
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Rob Barnes <robbarnes@google.com>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
This commit is contained in:
Karthikeyan Ramasubramanian 2021-10-25 23:26:25 -06:00 committed by Raul Rangel
parent 750abb1fe7
commit 30c441fc2d
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/mainboard/google/guybrush/variants/baseboard/gpio.c
View File

@ -95,8 +95,8 @@ static const struct soc_amd_gpio base_gpio_table[] = {
/* GPIO_77 - GPIO_83: Not available */
/* EC_SOC_INT_ODL */
PAD_GPI(GPIO_84, PULL_NONE),
/* WWAN_DISABLE */
PAD_GPO(GPIO_85, LOW),
/* Unused */
PAD_NC(GPIO_85),
/* ESPI_SOC_CLK */
PAD_NF(GPIO_86, SPI_CLK, PULL_NONE),
/* RAM_ID_1 / DEV_BEEP_DATA */
@ -198,8 +198,6 @@ static const struct soc_amd_gpio early_gpio_table[] = {
/* Put WWAN into reset */
/* WWAN_RST_L */
PAD_GPO(GPIO_24, LOW),
/* WWAN_DISABLE */
PAD_GPO(GPIO_85, HIGH),
/* Enable ESPI, GSC Interrupt & I2C Communication */
/* GSC_SOC_INT_L */
@ -261,8 +259,6 @@ static const struct soc_amd_gpio bootblock_gpio_table[] = {
/* Enable WWAN, Deassert WWAN reset, keep WWAN PCIe Aux reset asserted */
/* WWAN_RST_L */
PAD_GPO(GPIO_24, HIGH),
/* WWAN_DISABLE */
PAD_GPO(GPIO_85, LOW),
/* Enable WLAN */
/* WLAN_DISABLE */