AMD Agesa and GFXUMA: drop use of uma_memory_base

Without GFXUMA, variables were not referenced anywhere.
Fail builds on Family10 if GFXUMA is selected, because the northbridge
code does not set UMA base or size.

Change-Id: I15b91cf6241e9a890398eed03824b753828a0a51
Signed-off-by: Kyösti Mälkki <kyosti.malkki@gmail.com>
Reviewed-on: http://review.coreboot.org/1247
Reviewed-by: Zheng Bao <zheng.bao@amd.com>
Tested-by: build bot (Jenkins)
Reviewed-by: Anton Kochkov <anton.kochkov@gmail.com>
This commit is contained in:
Kyösti Mälkki 2012-07-20 08:31:37 +03:00 committed by Anton Kochkov
parent f803ac4a45
commit 30f04645c1
5 changed files with 4 additions and 12 deletions

View File

@ -923,6 +923,10 @@ static void amdfam10_domain_set_resources(device_t dev)
u32 reset_memhole = 1; u32 reset_memhole = 1;
#endif #endif
#if CONFIG_GFXUMA
#error Northbridge does not set uma_memory_base or uma_memory_size.
#endif
#if CONFIG_PCI_64BIT_PREF_MEM #if CONFIG_PCI_64BIT_PREF_MEM
for (link = dev->link_list; link; link = link->next) { for (link = dev->link_list; link; link = link->next) {

View File

@ -508,9 +508,6 @@ void setup_uma_memory(void)
__func__, uma_memory_size, uma_memory_base); __func__, uma_memory_size, uma_memory_base);
/* TODO: TOP_MEM2 */ /* TODO: TOP_MEM2 */
#else
uma_memory_size = 0x10000000; /* 256M recommended UMA */
uma_memory_base = 0x30000000; /* 1GB system memory supported */
#endif #endif
} }

View File

@ -553,9 +553,6 @@ void setup_uma_memory(void)
__func__, uma_memory_size, uma_memory_base); __func__, uma_memory_size, uma_memory_base);
/* TODO: TOP_MEM2 */ /* TODO: TOP_MEM2 */
#else
uma_memory_size = 0x10000000; /* 256M recommended UMA */
uma_memory_base = 0x30000000; /* 1GB system memory supported */
#endif #endif
} }

View File

@ -668,9 +668,6 @@ void setup_uma_memory(void)
__func__, uma_memory_size, uma_memory_base); __func__, uma_memory_size, uma_memory_base);
/* TODO: TOP_MEM2 */ /* TODO: TOP_MEM2 */
#else
uma_memory_size = 256 * ONE_MB; /* 256M recommended UMA */
uma_memory_base = 768 * ONE_MB; /* 1GB system memory supported */
#endif #endif
} }

View File

@ -677,9 +677,6 @@ void setup_uma_memory(void)
__func__, uma_memory_size, uma_memory_base); __func__, uma_memory_size, uma_memory_base);
/* TODO: TOP_MEM2 */ /* TODO: TOP_MEM2 */
#else
uma_memory_size = 256 << ONE_MB_SHIFT; /* 256M recommended UMA */
uma_memory_base = 768 << ONE_MB_SHIFT; /* 1GB system memory supported */
#endif #endif
} }