GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ec/google/wilco: Add a romstage init function to send progress code 

When using FSP with debug enabled it takes too long to get to ramstage
and send the first progress code to the EC.  The same thing has been
reported to happen when 2x16GB memory is installed.

BUG=b:127875364
TEST=boot with FSP debug and ensure EC does not try to turn off the
system while it is still booting.

Change-Id: I5676354f5e53540273a9029411507f91864735a1
Signed-off-by: Duncan Laurie <dlaurie@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32091
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
This commit is contained in:
Duncan Laurie 2019-03-27 19:28:17 -07:00 committed by Duncan Laurie
parent 13f5360724
commit 31354676d0
4 changed files with 51 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/ec/google/wilco/Makefile.inc
View File

@ -1,6 +1,7 @@
ifeq ($(CONFIG_EC_GOOGLE_WILCO),y)
bootblock-y += bootblock.c
romstage-y += commands.c mailbox.c romstage.c
ramstage-y += chip.c commands.c mailbox.c
smm-y += commands.c mailbox.c smihandler.c

1
src/ec/google/wilco/commands.h
View File

@ -63,6 +63,7 @@ enum set_acpi_mode_cmd {
};
enum bios_progress_code {
BIOS_PROGRESS_BEFORE_MEMORY = 0x00,
BIOS_PROGRESS_MEMORY_INIT = 0x01,
BIOS_PROGRESS_VIDEO_INIT = 0x02,
BIOS_PROGRESS_LOGO_DISPLAYED = 0x03,

23
src/ec/google/wilco/romstage.c Normal file
View File

@ -0,0 +1,23 @@
/*
* This file is part of the coreboot project.
*
* Copyright 2019 Google LLC
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
#include "commands.h"
#include "ec.h"
#include "romstage.h"
void wilco_ec_romstage_init(void)
{
wilco_ec_send(KB_BIOS_PROGRESS, BIOS_PROGRESS_BEFORE_MEMORY);
}

26
src/ec/google/wilco/romstage.h Normal file
View File

@ -0,0 +1,26 @@
/*
* This file is part of the coreboot project.
*
* Copyright 2019 Google LLC
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
#ifndef EC_GOOGLE_WILCO_ROMSTAGE_H
#define EC_GOOGLE_WILCO_ROMSTAGE_H
/**
* wilco_ec_early_init
*
* This function performs initialization of the EC in romstage.
*/
void wilco_ec_romstage_init(void);
#endif /* EC_GOOGLE_WILCO_ROMSTAGE_H */