soc/amd/common/block/acpimmio: add Kconfig option for biosram accessors

The biosram accessor support in soc/amd/common/block/acpimmio/biosram.c
is only used on Stoneyridge and the old amd/southbridge code and not on
Picasso or Cezanne. It also only builds as a 32 bit binary and breaks
when trying to build as a 64 bit binary, since the size of an uintptr_t
is different on those two. There is no support for using the 32 bit
binaryPI with a 64 bit coreboot while there is code to use a 32 bit FSP
with 64 bit coreboot, so not building this for FSP-based SoC support
moves us one step closer to be able to build coreboot as 64 bit binary
for Picasso and Cezanne.

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: I2d87ec2fa1b217eaf55d865e4390308812502e56
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56570
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Marshall Dawson <marshalldawson3rd@gmail.com>
This commit is contained in:
Felix Held 2021-07-23 19:18:02 +02:00
parent ee3d09b48e
commit 3136424e48
6 changed files with 16 additions and 2 deletions

View File

@ -3,3 +3,13 @@ config SOC_AMD_COMMON_BLOCK_ACPIMMIO
help help
Select this option to enable hardware blocks in the AcpiMmio Select this option to enable hardware blocks in the AcpiMmio
address space (0xfed8xxxx). address space (0xfed8xxxx).
if SOC_AMD_COMMON_BLOCK_ACPIMMIO
config SOC_AMD_COMMON_BLOCK_ACPIMMIO_BIOSRAM
bool
help
Add functions to access settings stored in the biosram region.
This is only used by the SoCs using binaryPI and the old AGESA.
endif # SOC_AMD_COMMON_BLOCK_ACPIMMIO

View File

@ -3,8 +3,8 @@ ifeq ($(CONFIG_SOC_AMD_COMMON_BLOCK_ACPIMMIO),y)
all-y += mmio_util.c all-y += mmio_util.c
smm-y += mmio_util.c smm-y += mmio_util.c
all-y += biosram.c all-$(CONFIG_SOC_AMD_COMMON_BLOCK_ACPIMMIO_BIOSRAM) += biosram.c
smm-y += biosram.c smm-$(CONFIG_SOC_AMD_COMMON_BLOCK_ACPIMMIO_BIOSRAM) += biosram.c
bootblock-y += print_reset_status.c bootblock-y += print_reset_status.c

View File

@ -26,6 +26,7 @@ config CPU_SPECIFIC_OPTIONS
select SOC_AMD_COMMON select SOC_AMD_COMMON
select SOC_AMD_COMMON_BLOCK_ACPI select SOC_AMD_COMMON_BLOCK_ACPI
select SOC_AMD_COMMON_BLOCK_ACPIMMIO select SOC_AMD_COMMON_BLOCK_ACPIMMIO
select SOC_AMD_COMMON_BLOCK_ACPIMMIO_BIOSRAM
select SOC_AMD_COMMON_BLOCK_AOAC select SOC_AMD_COMMON_BLOCK_AOAC
select SOC_AMD_COMMON_BLOCK_BANKED_GPIOS select SOC_AMD_COMMON_BLOCK_BANKED_GPIOS
select SOC_AMD_COMMON_BLOCK_CAR select SOC_AMD_COMMON_BLOCK_CAR

View File

@ -16,6 +16,7 @@ config SOUTHBRIDGE_SPECIFIC_OPTIONS
select HAVE_CF9_RESET_PREPARE select HAVE_CF9_RESET_PREPARE
select SOC_AMD_COMMON select SOC_AMD_COMMON
select SOC_AMD_COMMON_BLOCK_ACPIMMIO select SOC_AMD_COMMON_BLOCK_ACPIMMIO
select SOC_AMD_COMMON_BLOCK_ACPIMMIO_BIOSRAM
select SOC_AMD_COMMON_BLOCK_PCI_MMCONF select SOC_AMD_COMMON_BLOCK_PCI_MMCONF
config EHCI_BAR config EHCI_BAR

View File

@ -10,6 +10,7 @@ config SOUTHBRIDGE_AMD_CIMX_SB800
select HAVE_CF9_RESET_PREPARE select HAVE_CF9_RESET_PREPARE
select SOC_AMD_COMMON select SOC_AMD_COMMON
select SOC_AMD_COMMON_BLOCK_ACPIMMIO select SOC_AMD_COMMON_BLOCK_ACPIMMIO
select SOC_AMD_COMMON_BLOCK_ACPIMMIO_BIOSRAM
select SOC_AMD_COMMON_BLOCK_PCI_MMCONF select SOC_AMD_COMMON_BLOCK_PCI_MMCONF
if SOUTHBRIDGE_AMD_CIMX_SB800 if SOUTHBRIDGE_AMD_CIMX_SB800

View File

@ -16,6 +16,7 @@ config SOUTHBRIDGE_SPECIFIC_OPTIONS
select HAVE_CF9_RESET_PREPARE select HAVE_CF9_RESET_PREPARE
select SOC_AMD_COMMON select SOC_AMD_COMMON
select SOC_AMD_COMMON_BLOCK_ACPIMMIO select SOC_AMD_COMMON_BLOCK_ACPIMMIO
select SOC_AMD_COMMON_BLOCK_ACPIMMIO_BIOSRAM
select SOC_AMD_COMMON_BLOCK_BANKED_GPIOS select SOC_AMD_COMMON_BLOCK_BANKED_GPIOS
select SOC_AMD_COMMON_BLOCK_PCI_MMCONF select SOC_AMD_COMMON_BLOCK_PCI_MMCONF