soc/amd/common/espi_util: espi_send_command: improve error message

It's only an error if bits other than ESPI_STATUS_DNCMD_COMPLETE are set
in the status register. If ESPI_STATUS_DNCMD_COMPLETE isn't set, the
command failed, so we expect that one to be set.

Change-Id: I6f1fb5a59b1ecadd6724a07212626f21fb90e7e7
Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44352
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Felix Held 2020-08-10 20:42:20 +02:00
parent c0d4eeb387
commit 316d59c1aa
1 changed files with 2 additions and 1 deletions

View File

@ -470,7 +470,8 @@ static int espi_send_command(const struct espi_cmd *cmd)
} }
if (status & ~ESPI_STATUS_DNCMD_COMPLETE) { if (status & ~ESPI_STATUS_DNCMD_COMPLETE) {
espi_show_failure(cmd, "Error: eSPI status register bits set", status); espi_show_failure(cmd, "Error: unexpected eSPI status register bits set",
status);
return -1; return -1;
} }