Kconfig: Remove ACPI_SSDTX_NUM.

Its scope is limited to a single mainboard and is only to go through ifdef.
Kill it and move the value to the code.

Change-Id: I76a87e2790d57dee8f37b51e33d0689fffd3a59d
Signed-off-by: Vladimir Serbinenko <phcoder@gmail.com>
Reviewed-on: http://review.coreboot.org/7135
Tested-by: build bot (Jenkins)
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
Reviewed-by: Edward O'Callaghan <eocallaghan@alterapraxis.com>
This commit is contained in:
Vladimir Serbinenko 2014-10-20 19:38:27 +02:00
parent dc3d5ed3cb
commit 318e481e55
12 changed files with 2 additions and 42 deletions

View File

@ -356,10 +356,6 @@ config HAVE_ACPI_SLIC
bool bool
default n default n
config ACPI_SSDTX_NUM
int
default 0
config HAVE_HARD_RESET config HAVE_HARD_RESET
bool bool
default n default n

View File

@ -56,10 +56,6 @@ config IRQ_SLOT_COUNT
int int
default 11 default 11
config ACPI_SSDTX_NUM
int
default 0
config ONBOARD_VGA_IS_PRIMARY config ONBOARD_VGA_IS_PRIMARY
bool bool
default y default y

View File

@ -56,10 +56,6 @@ config IRQ_SLOT_COUNT
int int
default 11 default 11
config ACPI_SSDTX_NUM
int
default 0
config ONBOARD_VGA_IS_PRIMARY config ONBOARD_VGA_IS_PRIMARY
bool bool
default y default y

View File

@ -71,8 +71,4 @@ config IRQ_SLOT_COUNT
int int
default 11 default 11
config ACPI_SSDTX_NUM
int
default 4
endif # BOARD_AMD_SERENGETI_CHEETAH endif # BOARD_AMD_SERENGETI_CHEETAH

View File

@ -136,8 +136,6 @@ unsigned long mainboard_write_acpi_tables(unsigned long start, acpi_rsdp_t *rsdp
start = ALIGN(start, 16); start = ALIGN(start, 16);
current = start; current = start;
#if CONFIG_ACPI_SSDTX_NUM >= 1
//same htio, but different position? We may have to copy, change HCIN, and recalculate the checknum and add_table //same htio, but different position? We may have to copy, change HCIN, and recalculate the checknum and add_table
for(i=1;i<sysconf.hc_possible_num;i++) { // 0: is hc sblink for(i=1;i<sysconf.hc_possible_num;i++) { // 0: is hc sblink
@ -173,7 +171,6 @@ unsigned long mainboard_write_acpi_tables(unsigned long start, acpi_rsdp_t *rsdp
ssdtx->checksum = acpi_checksum((u8 *)ssdtx, ssdtx->length); ssdtx->checksum = acpi_checksum((u8 *)ssdtx, ssdtx->length);
acpi_add_table(rsdp, ssdtx); acpi_add_table(rsdp, ssdtx);
} }
#endif
return current; return current;
} }

View File

@ -12,7 +12,7 @@ Change dsdt.asl, according to MB layout
Change acpi_tables.c Change acpi_tables.c
sbdn: Real SB device Num. for 8111 =3 or 1 depend if 8131 presents. ---- Actually you don't need to change it, it is coreboot run-time configurable now. sbdn: Real SB device Num. for 8111 =3 or 1 depend if 8131 presents. ---- Actually you don't need to change it, it is coreboot run-time configurable now.
if there is HT-IO board, need to adjust SSDTX_NUM...., and preset pci1234 array. acpi_tables.c will decide to put the SSDT on the RSDT or not according if the HT-IO board is installed if there is HT-IO board, need to preset pci1234 array. acpi_tables.c will decide to put the SSDT on the RSDT or not according if the HT-IO board is installed
Regarding pci bridge apic and pic Regarding pci bridge apic and pic
need to modify entries amd8111.asl and amd8131.asl and amd8151.asl.... acording to your MB laybout, it is like that in mptable.c need to modify entries amd8111.asl and amd8131.asl and amd8151.asl.... acording to your MB laybout, it is like that in mptable.c

View File

@ -62,8 +62,4 @@ config AMD_UCODE_PATCH_FILE
string string
default "mc_patch_01000095.h" default "mc_patch_01000095.h"
config ACPI_SSDTX_NUM
int
default 5
endif # BOARD_AMD_SERENGETI_CHEETAH_FAM10 endif # BOARD_AMD_SERENGETI_CHEETAH_FAM10

View File

@ -30,12 +30,10 @@
#include "mb_sysconf.h" #include "mb_sysconf.h"
#include "mainboard.h" #include "mainboard.h"
#if CONFIG_ACPI_SSDTX_NUM >= 1
extern const unsigned char AmlCode_ssdt2[]; extern const unsigned char AmlCode_ssdt2[];
extern const unsigned char AmlCode_ssdt3[]; extern const unsigned char AmlCode_ssdt3[];
extern const unsigned char AmlCode_ssdt4[]; extern const unsigned char AmlCode_ssdt4[];
extern const unsigned char AmlCode_ssdt5[]; extern const unsigned char AmlCode_ssdt5[];
#endif
unsigned long acpi_fill_madt(unsigned long current) unsigned long acpi_fill_madt(unsigned long current)
{ {
@ -143,8 +141,6 @@ unsigned long mainboard_write_acpi_tables(unsigned long current,
get_bus_conf(); //it will get sblk, pci1234, hcdn, and sbdn get_bus_conf(); //it will get sblk, pci1234, hcdn, and sbdn
#if CONFIG_ACPI_SSDTX_NUM >= 1
/* same htio, but different possition? We may have to copy, /* same htio, but different possition? We may have to copy,
change HCIN, and recalculate the checknum and add_table */ change HCIN, and recalculate the checknum and add_table */
@ -182,7 +178,6 @@ unsigned long mainboard_write_acpi_tables(unsigned long current,
ssdtx->checksum = acpi_checksum((u8 *)ssdtx, ssdtx->length); ssdtx->checksum = acpi_checksum((u8 *)ssdtx, ssdtx->length);
acpi_add_table(rsdp, ssdtx); acpi_add_table(rsdp, ssdtx);
} }
#endif
return current; return current;
} }

View File

@ -57,10 +57,6 @@ config IRQ_SLOT_COUNT
int int
default 11 default 11
config ACPI_SSDTX_NUM
int
default 0
config ONBOARD_VGA_IS_PRIMARY config ONBOARD_VGA_IS_PRIMARY
bool bool
default y default y

View File

@ -54,8 +54,4 @@ config IRQ_SLOT_COUNT
int int
default 11 default 11
config ACPI_SSDTX_NUM
int
default 5
endif # BOARD_IWILL_DK8_HTX endif # BOARD_IWILL_DK8_HTX

View File

@ -49,8 +49,7 @@
* reset HC_POSSIBLE_NUM and update ssdt.dsl (hcdn, hclk) * reset HC_POSSIBLE_NUM and update ssdt.dsl (hcdn, hclk)
* *
* Put all the possible ht node/link to the list tp pci1234[] in get_bus_conf.c * Put all the possible ht node/link to the list tp pci1234[] in get_bus_conf.c
* on MB dir. Also, don't forget to increase the CONFIG_ACPI_SSDTX_NUM etc if you have * on MB dir. How about co-processor on socket 1 on 2 way system.
* too much SSDT. How about co-processor on socket 1 on 2 way system.
* or socket 2, and socket3 on 4 way system? treat that as one hc too! * or socket 2, and socket3 on 4 way system? treat that as one hc too!
* *
*/ */

View File

@ -176,9 +176,6 @@ unsigned node_link_to_bus(unsigned node, unsigned link)
* Just put all the possible HT Node/link to the list tp pci1234[] in * Just put all the possible HT Node/link to the list tp pci1234[] in
* src/mainboard/<vendor>/<mainboard>get_bus_conf.c * src/mainboard/<vendor>/<mainboard>get_bus_conf.c
* *
* Also don't forget to increase the CONFIG_ACPI_SSDTX_NUM etc (FIXME what else) if
* you have too many SSDTs
*
* What about co-processor in socket 1 on a 2 way system? Or socket 2 and * What about co-processor in socket 1 on a 2 way system? Or socket 2 and
* socket 3 on a 4 way system? Treat that as an HC, too! * socket 3 on a 4 way system? Treat that as an HC, too!
* *