GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

memory_info: add max_speed_mts and configured_speed_mts 

ddr_frequency is ambiguous and is interpreted differently in several
places. Instead of renaming this field, this deprecates it and adds
two new fields with unambiguous naming, max_speed_mts and
configured_speed_mts. smbios.c falls back to using ddr_frequency
when either of these fields are 0.

The same value was being used for both configured memory speed and
max memory speed in SMBIOS type 17, which is not accurate when
configured speed is not the max speed.

BUG=b:167218112
TEST=Boot ezkinil, no change to dmidecode -t17

Change-Id: Iaa75401f9fc33642dbdce6c69bd9b20f96d1cc25
Signed-off-by: Rob Barnes <robbarnes@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/44549
Reviewed-by: Furquan Shaikh <furquan@google.com>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Rob Barnes 2020-09-01 10:26:57 -06:00 committed by Aaron Durbin
parent 923b175f7e
commit 327f1058d2
2 changed files with 22 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/arch/x86/smbios.c
View File

@ -281,8 +281,14 @@ static int create_smbios_type17_for_dimm(struct dimm_info *dimm,
memset(t, 0, sizeof(struct smbios_type17));
t->memory_type = dimm->ddr_type;
t->clock_speed = dimm->ddr_frequency;
t->speed = dimm->ddr_frequency;
if (dimm->configured_speed_mts != 0)
t->clock_speed = dimm->configured_speed_mts;
else
t->clock_speed = dimm->ddr_frequency;
if (dimm->max_speed_mts != 0)
t->speed = dimm->max_speed_mts;
else
t->speed = dimm->ddr_frequency;
t->type = SMBIOS_MEMORY_DEVICE;
if (dimm->dimm_size < 0x7fff) {
t->size = dimm->dimm_size;

14
src/include/memory_info.h
View File

@ -28,6 +28,10 @@ struct dimm_info {
* See the smbios.h smbios_memory_type enum.
*/
uint16_t ddr_type;
/*
* ddr_frequency is deprecated.
* Use max_speed_mts and configured_speed_mts instead.
*/
uint16_t ddr_frequency;
uint8_t rank_per_dimm;
uint8_t channel_num;
@ -79,6 +83,16 @@ struct dimm_info {
* Voltage Level
*/
uint16_t vdd_voltage;
/*
* Max speed in MT/s
* If the value is 0, ddr_frequency should be used instead.
*/
uint16_t max_speed_mts;
/*
* Configured speed in MT/s
* If the value is 0, ddr_frequency should be used instead.
*/
uint16_t configured_speed_mts;
} __packed;
struct memory_info {