From 32b99169a56aa18047039092856a744d0e3d2d67 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Mon, 15 Feb 2021 13:08:19 +0200 Subject: [PATCH] mb/amd,google/zork: Move init_tables() call MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The semantics of pirq_setup() from previous platforms was to only setup the global pointers for PIC and APIC tables, not to create or modify the tables themselves. Change-Id: Iaa7c31eed21432dc2b3fe6b32803bd2658fd5e2d Signed-off-by: Kyösti Mälkki Reviewed-on: https://review.coreboot.org/c/coreboot/+/50717 Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons Reviewed-by: Felix Held --- src/mainboard/amd/bilby/mainboard.c | 2 +- src/mainboard/amd/majolica/mainboard.c | 2 +- src/mainboard/amd/mandolin/mainboard.c | 2 +- src/mainboard/google/zork/mainboard.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mainboard/amd/bilby/mainboard.c b/src/mainboard/amd/bilby/mainboard.c index 97acf6c97a..2bfdb59fa3 100644 --- a/src/mainboard/amd/bilby/mainboard.c +++ b/src/mainboard/amd/bilby/mainboard.c @@ -75,7 +75,6 @@ static void init_tables(void) static void pirq_setup(void) { - init_tables(); intr_data_ptr = fch_apic_routing; picr_data_ptr = fch_pic_routing; } @@ -100,6 +99,7 @@ static void bilby_enable(struct device *dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); + init_tables(); /* Initialize the PIRQ data structures for consumption */ pirq_setup(); } diff --git a/src/mainboard/amd/majolica/mainboard.c b/src/mainboard/amd/majolica/mainboard.c index cbb1145a69..bba6a5fefb 100644 --- a/src/mainboard/amd/majolica/mainboard.c +++ b/src/mainboard/amd/majolica/mainboard.c @@ -81,7 +81,6 @@ static void init_tables(void) static void pirq_setup(void) { - init_tables(); intr_data_ptr = fch_apic_routing; picr_data_ptr = fch_pic_routing; } @@ -94,6 +93,7 @@ static void majolica_enable(struct device *dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); + init_tables(); /* Initialize the PIRQ data structures for consumption */ pirq_setup(); } diff --git a/src/mainboard/amd/mandolin/mainboard.c b/src/mainboard/amd/mandolin/mainboard.c index 0d208da348..3513f614fe 100644 --- a/src/mainboard/amd/mandolin/mainboard.c +++ b/src/mainboard/amd/mandolin/mainboard.c @@ -75,7 +75,6 @@ static void init_tables(void) static void pirq_setup(void) { - init_tables(); intr_data_ptr = fch_apic_routing; picr_data_ptr = fch_pic_routing; } @@ -100,6 +99,7 @@ static void mandolin_enable(struct device *dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); + init_tables(); /* Initialize the PIRQ data structures for consumption */ pirq_setup(); } diff --git a/src/mainboard/google/zork/mainboard.c b/src/mainboard/google/zork/mainboard.c index 1558245773..06f4e8dda1 100644 --- a/src/mainboard/google/zork/mainboard.c +++ b/src/mainboard/google/zork/mainboard.c @@ -104,7 +104,6 @@ static void init_tables(void) /* PIRQ Setup */ static void pirq_setup(void) { - init_tables(); intr_data_ptr = fch_apic_routing; picr_data_ptr = fch_pic_routing; } @@ -202,6 +201,7 @@ static void zork_enable(struct device *dev) { printk(BIOS_INFO, "Mainboard " CONFIG_MAINBOARD_PART_NUMBER " Enable.\n"); + init_tables(); /* Initialize the PIRQ data structures for consumption */ pirq_setup();