GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/kahlee: Fix I2C bus 1 timing for Grunt 

I measured the rise and fall times for I2C bus 1 from userspace
manually, using "i2cdetect 1" called from userspace and an oscilloscope.

This commit fixes the values there to reflect reality.

BUG=b:72442912,b:70232394

Change-Id: I4f593cb2674006060cad9a77753c23f7d9828c9b
Signed-off-by: Justin TerAvest <teravest@chromium.org>
Reviewed-on: https://review.coreboot.org/23459
Reviewed-by: Martin Roth <martinroth@google.com>
Reviewed-by: Chris Ching <chingcodes@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Justin TerAvest 2018-01-26 15:19:08 -07:00 committed by Martin Roth
parent 763e493602
commit 339e771055
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/mainboard/google/kahlee/variants/grunt/devicetree.cb
View File

@ -28,11 +28,11 @@ chip soc/amd/stoneyridge
.fall_time_ns = 52,
}"
# TODO(teravest): Fix speeds here.
# Enable I2C1 for H1 at 400kHz
register "i2c[1]" = "{
.speed = I2C_SPEED_FAST,
.rise_time_ns = 104,
.fall_time_ns = 52,
.rise_time_ns = 84,
.fall_time_ns = 4,
}"
# TODO(teravest): Fix speeds here.