GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drivers/net/phy/m88e1512: Switch the page back to 0 only once 

When the configuration of Marvell PHY 88E1512 is finished, then switch
the page back to 0 only once at the end of the Init function.

Change-Id: I9e516870a7c5928724df2bd3ac9c5c8f3249af2e
Signed-off-by: Mario Scheithauer <mario.scheithauer@siemens.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73017
Reviewed-by: Werner Zeh <werner.zeh@siemens.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
This commit is contained in:
Mario Scheithauer 2023-01-25 10:19:51 +01:00 committed by Felix Held
parent e27f6543b6
commit 33ef5c4e3a
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/drivers/net/phy/m88e1512/m88e1512.c
View File

@ -52,9 +52,6 @@ static void m88e1512_init(struct device *dev)
clrsetbits16(&reg, LED_FUNC_CTRL_MASK, config->led_0_ctrl | clrsetbits16(&reg, LED_FUNC_CTRL_MASK, config->led_0_ctrl |
(config->led_1_ctrl << 4) | (config->led_2_ctrl << 8)); (config->led_1_ctrl << 4) | (config->led_2_ctrl << 8));
mdio_write(dev, LED_FUNC_CTRL_REG, reg); mdio_write(dev, LED_FUNC_CTRL_REG, reg);
/* Switch back to page 0. */
switch_page(dev, 0);
} }
/* INTn can be routed to LED[2] pin. */ /* INTn can be routed to LED[2] pin. */
@ -68,11 +65,11 @@ static void m88e1512_init(struct device *dev)
reg = mdio_read(dev, LED_TIMER_CTRL_REG); reg = mdio_read(dev, LED_TIMER_CTRL_REG);
setbits16(&reg, LED_IRQ_ENABLE); setbits16(&reg, LED_IRQ_ENABLE);
mdio_write(dev, LED_TIMER_CTRL_REG, reg); mdio_write(dev, LED_TIMER_CTRL_REG, reg);
}
/* Switch back to page 0. */ /* Switch back to page 0. */
switch_page(dev, 0); switch_page(dev, 0);
} }
}
struct device_operations m88e1512_ops = { struct device_operations m88e1512_ops = {
.read_resources = noop_read_resources, .read_resources = noop_read_resources,