GNUBoot/coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

soc/intel/{adl,ehl,tgl}: Rename spi_protection_mode to mfg_mode

Browse source 
Since TGL `spi_protection_mode` bit replaces the previous
`manufacturing mode` without changing the offset and purpose
of this bit.

This patch renames to `manufacturing mode` aka `mfg_mode` to
maintain the parity with other PCHs as part of IA-common code.

Signed-off-by: Subrata Banik <subratabanik@google.com>
Change-Id: I6d00f72ce7b3951120778733066c351986ccf343
Reviewed-on: https://review.coreboot.org/c/coreboot/+/60407
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Reviewed-by: EricR Lai <ericr_lai@compal.corp-partner.google.com>
This commit is contained in:
Subrata Banik 2021-12-27 16:31:24 +00:00
parent e065db0dc2
commit 346bb0b010
6 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/soc/intel/alderlake/include/soc/me.h
View file

@ -10,7 +10,7 @@ union me_hfsts1 {
u32 data;
struct {
u32 working_state: 4;
u32 spi_protection_mode: 1;
u32 mfg_mode: 1;
u32 fpt_bad: 1;
u32 operation_state: 3;
u32 fw_init_complete: 1;

4
src/soc/intel/alderlake/me.c
View file

@ -121,14 +121,14 @@ static void dump_me_status(void *unused)
* production system to indicate ME Manufacturing mode is disabled.
*/
printk(BIOS_DEBUG, "ME: Manufacturing Mode : %s\n",
((hfsts1.fields.spi_protection_mode == 0) &&
((hfsts1.fields.mfg_mode == 0) &&
(hfsts6.fields.fpf_soc_lock == 1)) ? "NO" : "YES");
/*
* The SPI Protection Mode bit reflects SPI descriptor
* locked(0) or unlocked(1).
*/
printk(BIOS_DEBUG, "ME: SPI Protection Mode Enabled : %s\n",
hfsts1.fields.spi_protection_mode ? "NO" : "YES");
hfsts1.fields.mfg_mode ? "NO" : "YES");
printk(BIOS_DEBUG, "ME: FW Partition Table : %s\n",
hfsts1.fields.fpt_bad ? "BAD" : "OK");
printk(BIOS_DEBUG, "ME: Bringup Loader Failure : %s\n",

2
src/soc/intel/elkhartlake/include/soc/me.h
View file

@ -8,7 +8,7 @@ union me_hfsts1 {
uint32_t data;
struct {
uint32_t working_state: 4;
uint32_t spi_protection_mode: 1;
uint32_t mfg_mode: 1;
uint32_t fpt_bad: 1;
uint32_t operation_state: 3;
uint32_t fw_init_complete: 1;

2
src/soc/intel/elkhartlake/me.c
View file

@ -32,7 +32,7 @@ static void dump_me_status(void *unused)
printk(BIOS_DEBUG, "ME: HFSTS6 : 0x%08X\n", hfsts6.data);
printk(BIOS_DEBUG, "ME: SPI Protection Mode : %s\n",
hfsts1.fields.spi_protection_mode ? "YES" : "NO");
hfsts1.fields.mfg_mode ? "YES" : "NO");
printk(BIOS_DEBUG, "ME: FW Partition Table : %s\n",
hfsts1.fields.fpt_bad ? "BAD" : "OK");
printk(BIOS_DEBUG, "ME: Bringup Loader Failure : %s\n",

2
src/soc/intel/tigerlake/include/soc/me.h
View file

@ -8,7 +8,7 @@ union me_hfsts1 {
u32 data;
struct {
u32 working_state: 4;
u32 spi_protection_mode: 1;
u32 mfg_mode: 1;
u32 fpt_bad: 1;
u32 operation_state: 3;
u32 fw_init_complete: 1;

4
src/soc/intel/tigerlake/me.c
View file

@ -121,14 +121,14 @@ static void dump_me_status(void *unused)
* production system to indicate ME Manufacturing mode is disabled.
*/
printk(BIOS_DEBUG, "ME: Manufacturing Mode : %s\n",
((hfsts1.fields.spi_protection_mode == 0) &&
((hfsts1.fields.mfg_mode == 0) &&
(hfsts6.fields.fpf_soc_lock == 1)) ? "NO" : "YES");
/*
* The SPI Protection Mode bit reflects SPI descriptor
* locked(0) or unlocked(1).
*/
printk(BIOS_DEBUG, "ME: SPI Protection Mode Enabled : %s\n",
hfsts1.fields.spi_protection_mode ? "NO" : "YES");
hfsts1.fields.mfg_mode ? "NO" : "YES");
printk(BIOS_DEBUG, "ME: FW Partition Table : %s\n",
hfsts1.fields.fpt_bad ? "BAD" : "OK");
printk(BIOS_DEBUG, "ME: Bringup Loader Failure : %s\n",