From 349a1452992ff6dc11dc874d7c11c50bf777a937 Mon Sep 17 00:00:00 2001 From: Felix Held Date: Tue, 20 Apr 2021 00:38:32 +0200 Subject: [PATCH] soc/amd/picasso/acp: rename acp_update32 mask parameters The name of the and_mask parameter was a bit misleading, due to the function inverting the value. Renaming this into clear and set makes it more obvious what those parameters will actually do. Signed-off-by: Felix Held Change-Id: If307ab4858541861e22f8ff24ed178d47ba70fe5 Reviewed-on: https://review.coreboot.org/c/coreboot/+/52524 Reviewed-by: Angel Pons Tested-by: build bot (Jenkins) --- src/soc/amd/picasso/acp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/soc/amd/picasso/acp.c b/src/soc/amd/picasso/acp.c index 69982f5dc6..822c48a119 100644 --- a/src/soc/amd/picasso/acp.c +++ b/src/soc/amd/picasso/acp.c @@ -15,13 +15,13 @@ #include #include -static void acp_update32(uintptr_t bar, uint32_t reg, uint32_t and_mask, uint32_t or_mask) +static void acp_update32(uintptr_t bar, uint32_t reg, uint32_t clear, uint32_t set) { uint32_t val; val = read32((void *)(bar + reg)); - val &= ~and_mask; - val |= or_mask; + val &= ~clear; + val |= set; write32((void *)(bar + reg), val); }