GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/kohaku: Assign GPP_A19 as reset_gpio of stylus 

Applying reset_gpio config of stylus for kohaku. GPP_A19 has been assigned in
the latest schematics.

We would keep GPP_A10 as output high for old revision devices temporarily.

BUG=b:141914474
BRANCH=none
TEST=verified stylus works internally
Signed-off-by: Seunghwan Kim <sh_.kim@samsung.com>

Change-Id: I61f0f9a4378f47bf455f0726d44beeaf2f67197b
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35748
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Shelley Chen <shchen@google.com>
This commit is contained in:
Seunghwan Kim 2019-10-02 11:38:12 +09:00 committed by Shelley Chen
parent 62e79d2c1e
commit 34d306ab18
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/mainboard/google/hatch/variants/kohaku/gpio.c
View File

@ -23,7 +23,7 @@ static const struct pad_config gpio_table[] = {
PAD_NC(GPP_A0, NONE),
/* A6 : SERIRQ ==> NC */
PAD_NC(GPP_A6, NONE),
/* A10 : PEN_RESET_ODL */
/* A10 : PEN_RESET_ODL for old revision devices */
PAD_CFG_GPO(GPP_A10, 1, DEEP),
/* A16 : EMR_GARAGE_DET (notification) */
PAD_CFG_GPI_GPIO_DRIVER(GPP_A16, NONE, PLTRST),
@ -31,8 +31,8 @@ static const struct pad_config gpio_table[] = {
PAD_NC(GPP_A17, NONE),
/* A18 : ISH_GP0 ==> NC */
PAD_NC(GPP_A18, NONE),
/* A19 : ISH_GP1 ==> NC */
PAD_NC(GPP_A19, NONE),
/* A19 : PEN_RESET_ODL */
PAD_CFG_GPO(GPP_A19, 0, DEEP),
/* A20 : ISH_GP2 ==> NC */
PAD_NC(GPP_A20, NONE),
/* A22 : ISH_GP4 ==> NC */

6
src/mainboard/google/hatch/variants/kohaku/overridetree.cb
View File

@ -189,10 +189,8 @@ chip soc/intel/cannonlake
register "generic.desc" = ""WCOM Digitizer""
register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C7_IRQ)"
register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C15)"
# TODO: We can't use GPP_A10 as reset_gpio due to its voltage level,
# so we need to reassign it or remove it.
#register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A10)"
#register "generic.reset_delay_ms" = "1"
register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_A19)"
register "generic.reset_delay_ms" = "1"
register "generic.has_power_resource" = "1"
register "hid_desc_reg_offset" = "0x1"
device i2c 0x09 on end