GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/dedede/var/shotzo: Add EC defines for ACPI 

Update Shotzo own ec.h with the battery, lid and ps2
defines stripped.

This is to ensure the correct ASL is generated so that we don't
advertise PS2 keyboard support and battery/lid interrupts which
don't exist.

In MAINBOARD_EC_SCI_EVENTS drop following events.
    EC_HOST_EVENT_LID_OPEN
    EC_HOST_EVENT_LID_CLOSED
    EC_HOST_EVENT_BATTERY_LOW
    EC_HOST_EVENT_BATTERY_CRITICAL
    EC_HOST_EVENT_BATTERY
    EC_HOST_EVENT_BATTERY_STATUS

set MAINBOARD_EC_SMI_EVENTS to 0 and drop
    EC_HOST_EVENT_LID_CLOSED smi event.

In MAINBOARD_EC_S5_WAKE_EVENTS drop below event.
    EC_HOST_EVENT_LID_OPEN

In MAINBOARD_EC_S3_WAKE_EVENTS drop following events.
  EC_HOST_EVENT_AC_CONNECTED
  EC_HOST_EVENT_AC_DISCONNECTED
  EC_HOST_EVENT_KEY_PRESSED
  EC_HOST_EVENT_KEY_PRESSED

BUG=b:235303242
BRANCH=dedede
TEST=Build

Change-Id: I5717e2e8ca7549d160fe46ccde31c6d7cf9649d7
Signed-off-by: Tony Huang <tony-huang@quanta.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/65167
Reviewed-by: Zhuohao Lee <zhuohao@google.com>
Reviewed-by: Eric Lai <eric_lai@quanta.corp-partner.google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Tony Huang 2022-06-16 14:37:19 +08:00 committed by Martin L Roth
parent edf71a08b4
commit 356f118379
1 changed files with 29 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/mainboard/google/dedede/variants/shotzo/include/variant/ec.h
View File

@ -5,4 +5,33 @@
#include <baseboard/ec.h> #include <baseboard/ec.h>
#undef MAINBOARD_EC_SCI_EVENTS
#define MAINBOARD_EC_SCI_EVENTS \
(EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_CONNECTED) |\
EC_HOST_EVENT_MASK(EC_HOST_EVENT_AC_DISCONNECTED) |\
EC_HOST_EVENT_MASK(EC_HOST_EVENT_THERMAL_THRESHOLD) |\
EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_START) |\
EC_HOST_EVENT_MASK(EC_HOST_EVENT_THROTTLE_STOP) |\
EC_HOST_EVENT_MASK(EC_HOST_EVENT_USB_CHARGER) |\
EC_HOST_EVENT_MASK(EC_HOST_EVENT_MKBP) |\
EC_HOST_EVENT_MASK(EC_HOST_EVENT_PD_MCU) |\
EC_HOST_EVENT_MASK(EC_HOST_EVENT_MODE_CHANGE))
#undef MAINBOARD_EC_SMI_EVENTS
#define MAINBOARD_EC_SMI_EVENTS 0
/* EC can wake from S5 with power button */
#undef MAINBOARD_EC_S5_WAKE_EVENTS
#define MAINBOARD_EC_S5_WAKE_EVENTS \
(EC_HOST_EVENT_MASK(EC_HOST_EVENT_POWER_BUTTON))
/* EC can wake from S3 with power button */
#undef MAINBOARD_EC_S3_WAKE_EVENTS
#define MAINBOARD_EC_S3_WAKE_EVENTS (MAINBOARD_EC_S5_WAKE_EVENTS)
/* Disaable LID switch */
#undef EC_ENABLE_LID_SWITCH
#undef SIO_EC_ENABLE_PS2K /* Disable PS/2 Keyboard */
#endif #endif