GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix build error introduced in r5868. 

aliased_name was a compatibility hack to match the output of the C rewrite
with the python version's results. It seems that we carried these
useless symbols with us for years, just without any impact good or bad.

By declaring devices static and tightening the screws (-Werror), the
compiler now knows that these declarations are useless - and stops.


Signed-off-by: Patrick Georgi <patrick.georgi@coresystems.de>
Acked-by: Stefan Reinauer <stefan.reinauer@coresystems.de>


git-svn-id: svn://svn.coreboot.org/coreboot/trunk@5687 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1
This commit is contained in:
Patrick Georgi 2010-08-09 12:58:16 +00:00
parent df61dd28f6
commit 35d346fe2d
2 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
util/sconfig/main.c
View File

@ -223,8 +223,6 @@ void alias_siblings(struct device *d) {
if (device_match(d, cmp)) {
d->multidev = 1;
cmp->aliased_name = malloc(12);
sprintf(cmp->aliased_name, "_dev%d", cmp->id);
cmp->id = d->id;
cmp->name = d->name;
cmp->used = 1;
@ -289,8 +287,6 @@ static void pass0(FILE *fil, struct device *ptr) {
if (ptr->children || ptr->multidev)
fprintf(fil, "struct bus %s_links[];\n", ptr->name);
}
if ((ptr->type == device) && (ptr->id != 0) && ptr->used)
fprintf(fil, "static struct device %s;\n", ptr->aliased_name);
}
static void pass1(FILE *fil, struct device *ptr) {

1
util/sconfig/sconfig.h
View File

@ -54,7 +54,6 @@ struct device {
int chiph_exists;
char *ops;
char *name;
char *aliased_name;
char *name_underscore;
char *path;
int path_a;