acpi: drop unused parameter from acpi_soc_fill_bert

Signed-off-by: Felix Held <felix-coreboot@felixheld.de>
Change-Id: Ic354824468f016a7857c6990024ae87db6fd00bf
Reviewed-on: https://review.coreboot.org/c/coreboot/+/55052
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Lance Zhao
This commit is contained in:
Felix Held 2021-05-28 15:54:21 +02:00
parent 67d958b640
commit 35efba2bc0
3 changed files with 4 additions and 6 deletions

View File

@ -1565,7 +1565,7 @@ bool __weak acpi_is_boot_error_src_present(void)
return false; return false;
} }
__weak void acpi_soc_fill_bert(acpi_bert_t *bert, void **region, size_t *length) {} __weak void acpi_soc_fill_bert(void **region, size_t *length) {}
unsigned long __weak fw_cfg_acpi_tables(unsigned long start) unsigned long __weak fw_cfg_acpi_tables(unsigned long start)
{ {
@ -1815,7 +1815,7 @@ unsigned long write_acpi_tables(unsigned long start)
size_t size; size_t size;
printk(BIOS_DEBUG, "ACPI: * BERT\n"); printk(BIOS_DEBUG, "ACPI: * BERT\n");
bert = (acpi_bert_t *) current; bert = (acpi_bert_t *) current;
acpi_soc_fill_bert(bert, &region, &size); acpi_soc_fill_bert(&region, &size);
acpi_write_bert(bert, (uintptr_t)region, size); acpi_write_bert(bert, (uintptr_t)region, size);
if (bert->header.length >= sizeof(acpi_bert_t)) { if (bert->header.length >= sizeof(acpi_bert_t)) {
current += bert->header.length; current += bert->header.length;

View File

@ -1342,7 +1342,7 @@ unsigned long acpi_create_lpi_desc_ncst(acpi_lpi_desc_ncst_t *lpi_desc, uint16_t
/* For crashlog. */ /* For crashlog. */
bool acpi_is_boot_error_src_present(void); bool acpi_is_boot_error_src_present(void);
void acpi_soc_fill_bert(acpi_bert_t *bert, void **region, size_t *length); void acpi_soc_fill_bert(void **region, size_t *length);
/* For ACPI S3 support. */ /* For ACPI S3 support. */
void __noreturn acpi_resume(void *wake_vec); void __noreturn acpi_resume(void *wake_vec);

View File

@ -8,9 +8,7 @@
#include <intelblocks/crashlog.h> #include <intelblocks/crashlog.h>
void acpi_soc_fill_bert(acpi_bert_t *bert, void acpi_soc_fill_bert(void **region, size_t *length)
void **region,
size_t *length)
{ {
acpi_generic_error_status_t *status = NULL; acpi_generic_error_status_t *status = NULL;
size_t cpu_record_size, pmc_record_size; size_t cpu_record_size, pmc_record_size;