GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mb/google/reef: Configure IRQs as level triggered for HID over I2C 

As per HID over I2C Protocol Specification[1] Version 1.00 Section 7.4,
the interrupt line used by the device is required to be level triggered.
Hence, this change updates the configuration of the HID over I2C devices
to be level triggered.

References:
[1] http://download.microsoft.com/download/7/d/d/7dd44bb7-2a7a-4505-ac1c-7227d3d96d5b/hid-over-i2c-protocol-spec-v1-0.docx

BUG=b:172846122
TEST=./util/abuild/abuild

Change-Id: Ifc6dd5f6549e7501f350afe8456a9a8096edcc25
Signed-off-by: Karthikeyan Ramasubramanian <kramasub@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/47425
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Karthikeyan Ramasubramanian 2020-11-10 14:57:10 -07:00 committed by Tim Wawrzynczak
parent c37e1e6d07
commit 3614270a76
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/mainboard/google/reef/variants/coral/devicetree.cb
View File

@ -220,7 +220,7 @@ chip soc/intel/apollolake
chip drivers/i2c/hid chip drivers/i2c/hid
register "generic.hid" = ""PNP0C50"" register "generic.hid" = ""PNP0C50""
register "generic.desc" = ""Synaptics Touchpad"" register "generic.desc" = ""Synaptics Touchpad""
register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPIO_18_IRQ)" register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_18_IRQ)"
register "generic.wake" = "GPE0_DW1_15" register "generic.wake" = "GPE0_DW1_15"
register "generic.probed" = "1" register "generic.probed" = "1"
register "hid_desc_reg_offset" = "0x20" register "hid_desc_reg_offset" = "0x20"

4
src/mainboard/google/reef/variants/snappy/devicetree.cb
View File

@ -236,7 +236,7 @@ chip soc/intel/apollolake
chip drivers/i2c/hid chip drivers/i2c/hid
register "generic.hid" = ""WDHT0002"" register "generic.hid" = ""WDHT0002""
register "generic.desc" = ""WDT Touchscreen"" register "generic.desc" = ""WDT Touchscreen""
register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPIO_21_IRQ)" register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_21_IRQ)"
register "generic.probed" = "1" register "generic.probed" = "1"
register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_36)" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_36)"
register "generic.reset_delay_ms" = "130" register "generic.reset_delay_ms" = "130"
@ -250,7 +250,7 @@ chip soc/intel/apollolake
chip drivers/i2c/hid chip drivers/i2c/hid
register "generic.hid" = ""GTCH7503"" register "generic.hid" = ""GTCH7503""
register "generic.desc" = ""G2TOUCH Touchscreen"" register "generic.desc" = ""G2TOUCH Touchscreen""
register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPIO_21_IRQ)" register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_21_IRQ)"
register "generic.probed" = "1" register "generic.probed" = "1"
register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_36)" register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_36)"
register "generic.reset_delay_ms" = "50" register "generic.reset_delay_ms" = "50"