soc/qualcomm: Increase SPI frequency to 75 MHz

Increase frequency of sc7280 to 75 MHz.  Setting the delay to 1/8 of
a cycle as a result of experimentation.

BUG=b:190231148
BRANCH=None
TEST=Make sure that herobrine board boots
     HW Engineer measured SPI frequency and verified running at 75 MHz

Signed-off-by: Shelley Chen <shchen@google.com>
Change-Id: I3cf5a7c85f12800a11ece397a354349f2a0a235f
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64673
Reviewed-by: Julius Werner <jwerner@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Shelley Chen 2022-05-11 18:29:19 -07:00
parent 84d54d40b8
commit 363202b435
5 changed files with 48 additions and 7 deletions

View File

@ -26,6 +26,7 @@ struct qcom_qspi_regs {
u32 current_mem_addr;
u32 hw_version;
u32 rd_fifo[16];
u32 sampling_clk_cfg;
};
check_member(qcom_qspi_regs, rd_fifo, 0x50);
@ -97,7 +98,16 @@ static struct qcom_qspi_regs * const qcom_qspi = (void *) QSPI_BASE;
#define QSPI_MAX_PACKET_COUNT 0xFFC0
void quadspi_init(uint32_t hz);
/*
* quadspi_init(): Configure SPI
*
* @param hz: SPI frequency in Hz
* @param sdelay: sampling delay in sdelay/8 cycle units example, if sdelay=1,
* then will delay sampling clock by 1/8 cycle. Note that
* setting sdelay to 4-7 would result in a negative sampling
* delay compared to 0.
*/
void quadspi_init(uint32_t hz, uint32_t sdelay);
int qspi_claim_bus(const struct spi_slave *slave);
int qspi_setup_bus(const struct spi_slave *slave);
void qspi_release_bus(const struct spi_slave *slave);

View File

@ -221,11 +221,26 @@ static void queue_data(uint8_t *data, uint32_t data_bytes,
queue_bounce_data(epilog_ptr, epilog_bytes, data_mode, write);
}
static void reg_init(void)
/*
* The way to encode the sampling delay is:
*
* QSPI_SAMPLE_CLK_CONFIG delay (cycle)
* ----------------------------------------
* 0xFFFh = 1111 1111 1111b 7/8
* 0xDB6h = 1101 1011 0110b 6/8
* 0xB6Dh = 1011 0110 1101b 5/8
* 0x924h = 1001 0010 0100b 4/8
* 0x6DBh = 0110 1101 1011b 3/8
* 0x492h = 0100 1001 0010b 2/8
* 0x249h = 0010 0100 1001b 1/8
* 0x000h = 0000 0000 0000b None
*/
static void reg_init(uint32_t sdelay)
{
uint32_t spi_mode;
uint32_t tx_data_oe_delay, tx_data_delay;
uint32_t mstr_config;
uint32_t sampling_delay;
spi_mode = 0;
@ -236,7 +251,6 @@ static void reg_init(void)
(tx_data_delay << TX_DATA_DELAY_SHIFT) | (SBL_EN) |
(spi_mode << SPI_MODE_SHIFT) |
(PIN_HOLDN) |
(FB_CLK_EN) |
(DMA_ENABLE) |
(FULL_CYCLE_MODE);
@ -246,14 +260,16 @@ static void reg_init(void)
write32(&qcom_qspi->mstr_int_sts, 0xFFFFFFFF);
write32(&qcom_qspi->rd_fifo_cfg, 0x0);
write32(&qcom_qspi->rd_fifo_rst, RESET_FIFO);
sampling_delay = sdelay << 9 | sdelay << 6 | sdelay << 3 | sdelay << 0;
write32(&qcom_qspi->sampling_clk_cfg, sampling_delay);
}
void quadspi_init(uint32_t hz)
void quadspi_init(uint32_t hz, uint32_t sdelay)
{
assert(dcache_line_bytes() == CACHE_LINE_SIZE);
clock_configure_qspi(hz * 4);
configure_gpios();
reg_init();
reg_init(sdelay);
}
int qspi_claim_bus(const struct spi_slave *slave)

View File

@ -8,6 +8,6 @@
void bootblock_soc_init(void)
{
clock_init();
quadspi_init(37500 * KHz);
quadspi_init(37500 * KHz, 0);
qupv3_fw_init();
}

View File

@ -8,6 +8,11 @@
void bootblock_soc_init(void)
{
clock_init();
quadspi_init(50000 * KHz);
/*
* Through experimentation, we have determined
* that a delay of 1/8 cycle is best for herobrine.
* See b/190231148
*/
quadspi_init(75000 * KHz, 1);
qupv3_fw_init();
}

View File

@ -27,6 +27,16 @@ static struct clock_freq_config qspi_core_cfg[] = {
.src = SRC_GPLL0_MAIN_600MHZ,
.div = QCOM_CLOCK_DIV(3),
},
{
.hz = 240 * MHz,
.src = SRC_GPLL0_MAIN_600MHZ,
.div = QCOM_CLOCK_DIV(2.5),
},
{
.hz = 300 * MHz,
.src = SRC_GPLL0_MAIN_600MHZ,
.div = QCOM_CLOCK_DIV(2),
},
{
.hz = 400 * MHz,
.src = SRC_GPLL0_MAIN_600MHZ,