GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

src/lib: Clean up general issues found by checkpatch.pl 

Fix the following errors and warnings detected by checkpatch.pl:

ERROR: Bad function definition - void init_timer() should probably be void init_timer(void)
ERROR: Prefixing 0x with decimal output is defective
WARNING: Comparisons should place the constant on the right side of the test
WARNING: char * array declaration might be better as static const

TEST=Build and run on Galileo Gen2

Change-Id: I9f618eea95e1f92fa34f4f89da27c0b16ae7f4ee
Signed-off-by: Lee Leahy <Leroy.P.Leahy@intel.com>
Reviewed-on: https://review.coreboot.org/18763
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Lee Leahy 2017-03-10 17:56:44 -08:00
parent 491c5b60d0
commit 36984d85e7
5 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/lib/edid.c
View File

@ -117,7 +117,7 @@ static int
detailed_cvt_descriptor(unsigned char *x, int first) detailed_cvt_descriptor(unsigned char *x, int first)
{ {
const unsigned char empty[3] = { 0, 0, 0 }; const unsigned char empty[3] = { 0, 0, 0 };
const char *names[] = { "50", "60", "75", "85" }; static const char *names[] = { "50", "60", "75", "85" };
int width = 0, height = 0; int width = 0, height = 0;
int valid = 1; int valid = 1;
int fifty = 0, sixty = 0, seventyfive = 0, eightyfive = 0, reduced = 0; int fifty = 0, sixty = 0, seventyfive = 0, eightyfive = 0, reduced = 0;

2
src/lib/gcov-glue.c
View File

@ -114,7 +114,7 @@ static size_t fread(void *ptr, size_t size, size_t nmemb, FILE *stream)
static size_t fwrite(const void *ptr, size_t size, size_t nmemb, FILE *stream) static size_t fwrite(const void *ptr, size_t size, size_t nmemb, FILE *stream)
{ {
#if CONFIG_DEBUG_COVERAGE #if CONFIG_DEBUG_COVERAGE
printk(BIOS_DEBUG, "fwrite: %zd * 0x%zd bytes to file %s\n", printk(BIOS_DEBUG, "fwrite: %zd * %zd bytes to file %s\n",
nmemb, size, stream->filename); nmemb, size, stream->filename);
#endif #endif
// TODO check if file is last opened file and fail otherwise. // TODO check if file is last opened file and fail otherwise.

4
src/lib/reg_script.c
View File

@ -476,7 +476,7 @@ static uint64_t reg_script_read(struct reg_script_context *ctx)
/* Read from the platform specific bus */ /* Read from the platform specific bus */
bus = find_bus(step); bus = find_bus(step);
if (NULL != bus) { if (bus != NULL) {
value = bus->reg_script_read(ctx); value = bus->reg_script_read(ctx);
break; break;
} }
@ -530,7 +530,7 @@ static void reg_script_write(struct reg_script_context *ctx)
/* Write to the platform specific bus */ /* Write to the platform specific bus */
bus = find_bus(step); bus = find_bus(step);
if (NULL != bus) { if (bus != NULL) {
bus->reg_script_write(ctx); bus->reg_script_write(ctx);
break; break;
} }

2
src/lib/timer.c
View File

@ -18,7 +18,7 @@
#include <delay.h> #include <delay.h>
#include <thread.h> #include <thread.h>
__attribute__((weak)) void init_timer() { /* do nothing */ } __attribute__((weak)) void init_timer(void) { /* do nothing */ }
void udelay(unsigned int usec) void udelay(unsigned int usec)
{ {

2
src/lib/tlcl.c
View File

@ -86,7 +86,7 @@ static uint32_t tlcl_send_receive_no_retry(const uint8_t *request,
result = tpm_send_receive(request, tpm_command_size(request), result = tpm_send_receive(request, tpm_command_size(request),
response, &response_length); response, &response_length);
if (0 != result) { if (result != 0) {
/* Communication with TPM failed, so response is garbage */ /* Communication with TPM failed, so response is garbage */
VBDEBUG("TPM: command 0x%x send/receive failed: 0x%x\n", VBDEBUG("TPM: command 0x%x send/receive failed: 0x%x\n",
tpm_command_code(request), result); tpm_command_code(request), result);