GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mainboard/hp/dl165_g6_fam10: Fix coding style 

Change-Id: I3e3bb9a0e9670fca67016523eac437140ff03188
Signed-off-by: Elyes HAOUAS <ehaouas@noos.fr>
Reviewed-on: https://review.coreboot.org/23533
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Held <felix-coreboot@felixheld.de>
This commit is contained in:
Elyes HAOUAS 2018-02-01 09:18:58 +01:00 committed by Felix Held
parent cee9b6ee30
commit 36ece9380a
2 changed files with 11 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/mainboard/hp/dl165_g6_fam10/get_bus_conf.c
View File

@ -69,7 +69,8 @@ void get_bus_conf(void)
int i; int i;
struct mb_sysconf_t *m; struct mb_sysconf_t *m;
if(get_bus_conf_done == 1) return; //do it only once if (get_bus_conf_done == 1)
return; //do it only once
get_bus_conf_done = 1; get_bus_conf_done = 1;
@ -80,7 +81,7 @@ void get_bus_conf(void)
sysconf.hc_possible_num = ARRAY_SIZE(pci1234x); sysconf.hc_possible_num = ARRAY_SIZE(pci1234x);
for(i = 0; i < sysconf.hc_possible_num; i++) { for (i = 0; i < sysconf.hc_possible_num; i++) {
sysconf.pci1234[i] = pci1234x[i]; sysconf.pci1234[i] = pci1234x[i];
sysconf.hcdn[i] = hcdnx[i]; sysconf.hcdn[i] = hcdnx[i];
} }
@ -102,28 +103,24 @@ void get_bus_conf(void)
printk(BIOS_DEBUG, "secondary is %d...\n",m->bus_bcm5785_1); printk(BIOS_DEBUG, "secondary is %d...\n",m->bus_bcm5785_1);
dev = dev_find_slot(m->bus_bcm5785_1, PCI_DEVFN(0xd,0)); dev = dev_find_slot(m->bus_bcm5785_1, PCI_DEVFN(0xd,0));
printk(BIOS_DEBUG, "now found %s...\n",dev_path(dev)); printk(BIOS_DEBUG, "now found %s...\n",dev_path(dev));
if(dev) { if (dev)
m->bus_bcm5785_1_1 = pci_read_config8(dev, PCI_SECONDARY_BUS); m->bus_bcm5785_1_1 = pci_read_config8(dev, PCI_SECONDARY_BUS);
}
} }
else { else {
printk(BIOS_DEBUG, "ERROR - could not find PCI %02x:%02x.0, using defaults\n", m->bus_bcm5785_0, sysconf.sbdn); printk(BIOS_DEBUG, "ERROR - could not find PCI %02x:%02x.0, using defaults\n", m->bus_bcm5785_0, sysconf.sbdn);
} }
/* bcm5780 */ /* bcm5780 */
for(i = 1; i < 6; i++) { for (i = 1; i < 6; i++) {
dev = dev_find_slot(m->bus_bcm5780[0], PCI_DEVFN(m->sbdn2 + i - 1,0)); dev = dev_find_slot(m->bus_bcm5780[0], PCI_DEVFN(m->sbdn2 + i - 1,0));
if(dev) { if (dev)
m->bus_bcm5780[i] = pci_read_config8(dev, PCI_SECONDARY_BUS); m->bus_bcm5780[i] = pci_read_config8(dev, PCI_SECONDARY_BUS);
else
}
else {
printk(BIOS_DEBUG, "ERROR - could not find PCI %02x:%02x.0, using defaults\n", m->bus_bcm5780[0], m->sbdn2+i-1); printk(BIOS_DEBUG, "ERROR - could not find PCI %02x:%02x.0, using defaults\n", m->bus_bcm5780[0], m->sbdn2+i-1);
}
} }
/*I/O APICs: APIC ID Version State Address*/ /*I/O APICs: APIC ID Version State Address*/
apicid_base = 0x10; apicid_base = 0x10;
for(i = 0; i < 3; i++) for (i = 0; i < 3; i++)
m->apicid_bcm5785[i] = apicid_base+i; m->apicid_bcm5785[i] = apicid_base+i;
} }

6
src/mainboard/hp/dl165_g6_fam10/mptable.c
View File

@ -58,7 +58,7 @@ static void *smp_write_config_table(void *v)
device_t dev = 0; device_t dev = 0;
int i; int i;
struct resource *res; struct resource *res;
for(i = 0; i < 3; i++) { for (i = 0; i < 3; i++) {
dev = dev_find_device(0x1166, 0x0235, dev); dev = dev_find_device(0x1166, 0x0235, dev);
if (dev) { if (dev) {
res = find_resource(dev, PCI_BASE_ADDRESS_0); res = find_resource(dev, PCI_BASE_ADDRESS_0);
@ -86,7 +86,7 @@ static void *smp_write_config_table(void *v)
{ {
device_t dev; device_t dev;
dev = dev_find_device(0x1166, 0x0205, 0); dev = dev_find_device(0x1166, 0x0205, 0);
if(dev) { if (dev) {
uint32_t dword; uint32_t dword;
dword = pci_read_config32(dev, 0x64); dword = pci_read_config32(dev, 0x64);
dword |= (1 << 30); // GEVENT14-21 used as PCI IRQ0-7 dword |= (1 << 30); // GEVENT14-21 used as PCI IRQ0-7
@ -129,7 +129,7 @@ static void *smp_write_config_table(void *v)
{ {
device_t dev; device_t dev;
dev = dev_find_device(0x1166, 0x0205, 0); dev = dev_find_device(0x1166, 0x0205, 0);
if(dev) { if (dev) {
uint32_t dword; uint32_t dword;
dword = pci_read_config32(dev, 0x6c); dword = pci_read_config32(dev, 0x6c);
dword |= (1 << 4); // enable interrupts dword |= (1 << 4); // enable interrupts