GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

sb/intel: Drop outdated SMBus I/O BAR comment 

The SMBus I/O bar is not relocated because it's reported to the
allocator as a fixed resource. Drop these out-of-date comments.

Change-Id: I0149764fd231b3a4e56a5a9b7f4ae61f7954cf7a
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/54329
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
This commit is contained in:
Angel Pons 2021-05-16 13:08:46 +02:00 committed by David Hendricks
parent 1e66479e93
commit 3704c65f08
4 changed files with 0 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/southbridge/intel/bd82x6x/pch.h
View File

@ -17,14 +17,6 @@
#define PCH_STEP_B2 4 #define PCH_STEP_B2 4
#define PCH_STEP_B3 5 #define PCH_STEP_B3 5
/*
* It does not matter where we put the SMBus I/O base, as long as we
* keep it consistent and don't interfere with other devices. Stage2
* will relocate this anyways.
* Our solution is to have SMB initialization move the I/O to CONFIG_FIXED_SMBUS_IO_BASE
* again. But handling static BARs is a generic problem that should be
* solved in the device allocator.
*/
#define SMBUS_SLAVE_ADDR 0x24 #define SMBUS_SLAVE_ADDR 0x24
/* TODO Make sure these don't get changed by stage2 */ /* TODO Make sure these don't get changed by stage2 */
#define DEFAULT_GPIOBASE 0x0480 #define DEFAULT_GPIOBASE 0x0480

8
src/southbridge/intel/i82801gx/i82801gx.h
View File

@ -3,14 +3,6 @@
#ifndef SOUTHBRIDGE_INTEL_I82801GX_I82801GX_H #ifndef SOUTHBRIDGE_INTEL_I82801GX_I82801GX_H
#define SOUTHBRIDGE_INTEL_I82801GX_I82801GX_H #define SOUTHBRIDGE_INTEL_I82801GX_I82801GX_H
/*
* It does not matter where we put the SMBus I/O base, as long as we
* keep it consistent and don't interfere with other devices. Stage2
* will relocate this anyways.
* Our solution is to have SMB initialization move the I/O to CONFIG_FIXED_SMBUS_IO_BASE
* again. But handling static BARs is a generic problem that should be
* solved in the device allocator.
*/
/* TODO Make sure these don't get changed by stage2 */ /* TODO Make sure these don't get changed by stage2 */
#define DEFAULT_GPIOBASE 0x0480 #define DEFAULT_GPIOBASE 0x0480
#define DEFAULT_PMBASE 0x0500 #define DEFAULT_PMBASE 0x0500

8
src/southbridge/intel/ibexpeak/pch.h
View File

@ -18,14 +18,6 @@
#define PCH_STEP_B2 4 #define PCH_STEP_B2 4
#define PCH_STEP_B3 5 #define PCH_STEP_B3 5
/*
* It does not matter where we put the SMBus I/O base, as long as we
* keep it consistent and don't interfere with other devices. Stage2
* will relocate this anyways.
* Our solution is to have SMB initialization move the I/O to CONFIG_FIXED_SMBUS_IO_BASE
* again. But handling static BARs is a generic problem that should be
* solved in the device allocator.
*/
#define SMBUS_SLAVE_ADDR 0x24 #define SMBUS_SLAVE_ADDR 0x24
/* TODO Make sure these don't get changed by stage2 */ /* TODO Make sure these don't get changed by stage2 */
#define DEFAULT_GPIOBASE 0x0480 #define DEFAULT_GPIOBASE 0x0480

8
src/southbridge/intel/lynxpoint/pch.h
View File

@ -43,14 +43,6 @@
#define LPT_LP_STEP_B1 0x03 #define LPT_LP_STEP_B1 0x03
#define LPT_LP_STEP_B2 0x04 #define LPT_LP_STEP_B2 0x04
/*
* It does not matter where we put the SMBus I/O base, as long as we
* keep it consistent and don't interfere with other devices. Stage2
* will relocate this anyways.
* Our solution is to have SMB initialization move the I/O to CONFIG_FIXED_SMBUS_IO_BASE
* again. But handling static BARs is a generic problem that should be
* solved in the device allocator.
*/
#define SMBUS_SLAVE_ADDR 0x24 #define SMBUS_SLAVE_ADDR 0x24
#if CONFIG(INTEL_LYNXPOINT_LP) #if CONFIG(INTEL_LYNXPOINT_LP)