From 3790a420036874f3d8e01f4f4cf1340f657242d2 Mon Sep 17 00:00:00 2001 From: Brandon Breitenstein Date: Sat, 4 Jun 2016 00:52:21 +0200 Subject: [PATCH] Revert "soc/intel/apollolake: Do not use StackBase FSP-M parameter" This reverts commit 5ede3d8ccebde6f26c6b24f6458e57d99d5f3957. No longer needed due to FSP being updated, with the 139_40 release, to accept StackBase field BUG=chrome-os-partner:52784 BRANCH=none TEST=built and booted with FSP 139_40 Change-Id: Ic832d8dc4ca87631f5fef80d4d41558d9a72630a Signed-off-by: Brandon Breitenstein Reviewed-on: https://review.coreboot.org/15068 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin --- src/soc/intel/apollolake/romstage.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/soc/intel/apollolake/romstage.c b/src/soc/intel/apollolake/romstage.c index dec5a18601..756e27534a 100644 --- a/src/soc/intel/apollolake/romstage.c +++ b/src/soc/intel/apollolake/romstage.c @@ -235,13 +235,9 @@ void platform_fsp_memory_init_params_cb(struct FSPM_UPD *mupd) * requests. * TODO: add checks to avoid overlap/conflict of CAR usage. */ - - /* fsp does not work with StackBase modified, so use default */ -#if 0 - /* FIXME: remove this once FSP is fixed */ mupd->FspmArchUpd.StackBase = _car_region_end - mupd->FspmArchUpd.StackSize; -#endif + arch_upd->BootMode = FSP_BOOT_WITH_FULL_CONFIGURATION; if (IS_ENABLED(CONFIG_CACHE_MRC_SETTINGS)) {