GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

soc/intel/common/block/acpi: Factor out common ish.asl 

This patch moves ish.asl into common block acpi directory to
avoid duplicating the same ASL code block across SoC directory.

TEST=Able to build and boot TGL, CML platform.
1) Dump and disassemble DSDT, verify ISHB device present inside
common ish.asl is still there with correct _ADR value.
2) Verify no ACPI error seen while running 'dmesg` from console.

CML platform:

Device (ISHB)
{
  Name (_ADR, 0x00130000)  // _ADR: Address
  Name (_DDN, "Integrated Sensor Hub Controller")  //_DDN: DOS Device Name
}

TGL/JSL platform:

Device (ISHB)
{
  Name (_ADR, 0x00120000)  // _ADR: Address
  Name (_DDN, "Integrated Sensor Hub Controller")  //_DDN: DOS Device Name
}

Signed-off-by: Subrata Banik <subrata.banik@intel.com>
Change-Id: I33c1649d7a632c7b147e1bf307cfb5c1dfd84c0c
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45995
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Subrata Banik 2020-10-04 14:16:31 +05:30
parent b70c66b00d
commit 37a42da465
7 changed files with 14 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/soc/intel/cannonlake/acpi/ish.asl
View File

@ -1,9 +0,0 @@
/* SPDX-License-Identifier: GPL-2.0-only */
/* Intel Integrated Sensor Hub Controller 0:13.0 */
Device (ISHB)
{
Name (_ADR, 0x00130000)
Name (_DDN, "Integrated Sensor Hub Controller")
}

2
src/soc/intel/cannonlake/acpi/southbridge.asl
View File

@ -35,7 +35,7 @@
#include <soc/intel/common/block/acpi/acpi/smbus.asl> #include <soc/intel/common/block/acpi/acpi/smbus.asl>
/* ISH 0:13.0 */ /* ISH 0:13.0 */
#include "ish.asl" #include <soc/intel/common/block/acpi/acpi/ish.asl>
/* USB XHCI 0:14.0 */ /* USB XHCI 0:14.0 */
#include "xhci.asl" #include "xhci.asl"

11
src/soc/intel/common/block/acpi/acpi/ish.asl Normal file
View File

@ -0,0 +1,11 @@
/* SPDX-License-Identifier: GPL-2.0-only */
#include <soc/pci_devs.h>
/* Calculate _ADR for Intel Integrated Sensor Hub Controller */
#define ISH_ACPI_DEVICE (PCH_DEV_SLOT_ISH << 16 | 0x0000)
Device (ISHB)
{
Name (_ADR, ISH_ACPI_DEVICE)
Name (_DDN, "Integrated Sensor Hub Controller")
}

9
src/soc/intel/jasperlake/acpi/ish.asl
View File

@ -1,9 +0,0 @@
/* SPDX-License-Identifier: GPL-2.0-only */
/* Intel Integrated Sensor Hub Controller 0:12.0 */
Device (ISHB)
{
Name (_ADR, 0x00120000)
Name (_DDN, "Integrated Sensor Hub Controller")
}

2
src/soc/intel/jasperlake/acpi/southbridge.asl
View File

@ -36,7 +36,7 @@
#include <soc/intel/common/block/acpi/acpi/smbus.asl> #include <soc/intel/common/block/acpi/acpi/smbus.asl>
/* ISH 0:12.0 */ /* ISH 0:12.0 */
#include "ish.asl" #include <soc/intel/common/block/acpi/acpi/ish.asl>
/* USB XHCI 0:14.0 */ /* USB XHCI 0:14.0 */
#include "xhci.asl" #include "xhci.asl"

9
src/soc/intel/tigerlake/acpi/ish.asl
View File

@ -1,9 +0,0 @@
/* SPDX-License-Identifier: GPL-2.0-only */
/* Intel Integrated Sensor Hub Controller 0:12.0 */
Device (ISHB)
{
Name (_ADR, 0x00120000)
Name (_DDN, "Integrated Sensor Hub Controller")
}

2
src/soc/intel/tigerlake/acpi/southbridge.asl
View File

@ -33,7 +33,7 @@
#include <soc/intel/common/block/acpi/acpi/smbus.asl> #include <soc/intel/common/block/acpi/acpi/smbus.asl>
/* ISH 0:12.0 */ /* ISH 0:12.0 */
#include "ish.asl" #include <soc/intel/common/block/acpi/acpi/ish.asl>
/* USB XHCI 0:14.0 */ /* USB XHCI 0:14.0 */
#include "xhci.asl" #include "xhci.asl"