GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mainboard/google/reef: drop remaining proto board references 

The last vestige of the proto boards is the memory sku id
gpios. The internal pullups are still required because there's
only pulldown stuffing options available on the reef boards.

BUG=chrome-os-partner:56791

Change-Id: I04d541a897ec9aacbf2011293d18242fa32896d2
Signed-off-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-on: https://review.coreboot.org/16432
Tested-by: build bot (Jenkins)
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Reviewed-by: Furquan Shaikh <furquan@google.com>
This commit is contained in:
Aaron Durbin 2016-09-02 20:29:39 -05:00
parent 8db1f8dabb
commit 37ddb630dd
2 changed files with 3 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/mainboard/google/reef/variants/baseboard/include/baseboard/gpio.h
View File

@ -39,11 +39,7 @@
#define GPIO_PCH_WP GPIO_75 #define GPIO_PCH_WP GPIO_75
#define GPIO_EC_IN_RW GPIO_41 #define GPIO_EC_IN_RW GPIO_41
/* /* Memory SKU GPIOs. */
* The proto boards didn't have memory SKU pins, but the same ones can be
* utilized as post proto boards because the pins used were never connected
* or no peripheral utilized the signals on proto boards.
*/
#define MEM_CONFIG3 GPIO_45 #define MEM_CONFIG3 GPIO_45
#define MEM_CONFIG2 GPIO_38 #define MEM_CONFIG2 GPIO_38
#define MEM_CONFIG1 GPIO_102 #define MEM_CONFIG1 GPIO_102

21
src/mainboard/google/reef/variants/baseboard/memory.c
View File

@ -62,14 +62,6 @@ const struct lpddr4_swizzle_cfg baseboard_lpddr4_swizzle = {
}, },
}; };
/*
* Proto boards didn't have a memory SKU id. The configuration pins use
* an internal weak pullup with stronger pulldowns for the 0 bits. As
* proto boards didn't use the memory SKU pins the SKU id reads as 4'b1111,
* i.e. 15.
*/
#define PROTO_SKU 15
static const struct lpddr4_sku skus[] = { static const struct lpddr4_sku skus[] = {
/* /*
* K4F6E304HB-MGCJ - both logical channels While the parts * K4F6E304HB-MGCJ - both logical channels While the parts
@ -133,13 +125,6 @@ static const struct lpddr4_sku skus[] = {
.ch1_rank_density = LP4_8Gb_DENSITY, .ch1_rank_density = LP4_8Gb_DENSITY,
.part_num = "H9HCNNN8KUMLHR", .part_num = "H9HCNNN8KUMLHR",
}, },
/* K4F8E304HB-MGCH - both logical channels */
[PROTO_SKU] = {
.speed = LP4_SPEED_2400,
.ch0_rank_density = LP4_8Gb_DENSITY,
.ch1_rank_density = LP4_8Gb_DENSITY,
.part_num = "K4F8E304HB-MGCH",
},
}; };
static const struct lpddr4_cfg lp4cfg = { static const struct lpddr4_cfg lp4cfg = {
@ -160,9 +145,7 @@ size_t __attribute__((weak)) variant_memory_sku(void)
[1] = MEM_CONFIG1, [0] = MEM_CONFIG0, [1] = MEM_CONFIG1, [0] = MEM_CONFIG0,
}; };
/* /* Need internal pullups enabled as only pulldown stuffing options
* Read memory SKU id with internal pullups enabled to handle * exist. */
* proto boards with no SKU id pins.
*/
return gpio_pullup_base2_value(pads, ARRAY_SIZE(pads)); return gpio_pullup_base2_value(pads, ARRAY_SIZE(pads));
} }