From 380411422eb8b54abbf6cd60a5692ffd9c390e56 Mon Sep 17 00:00:00 2001 From: Karthikeyan Ramasubramanian Date: Mon, 19 Dec 2022 11:46:07 -0700 Subject: [PATCH] mb/google/skyrim: Fix Bluetooth configuration Power resource for Bluetooth device is not configured correctly in the device tree. Fix Bluetooth devicetree configuration. BUG=b:262785310 TEST=Build Skyrim BIOS image and boot to OS. Ensure that the DUT is able to connect to a Bluetooth headset. Change-Id: Id980424349537be35860dec04cc823d419cefe2f Signed-off-by: Karthikeyan Ramasubramanian Reviewed-on: https://review.coreboot.org/c/coreboot/+/71068 Reviewed-by: Raul Rangel Reviewed-by: Tim Van Patten Tested-by: build bot (Jenkins) --- .../google/skyrim/variants/baseboard/devicetree.cb | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb b/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb index 52019abf30..a0d38300e3 100644 --- a/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/skyrim/variants/baseboard/devicetree.cb @@ -171,7 +171,12 @@ chip soc/amd/mendocino chip drivers/usb/acpi register "desc" = ""Bluetooth"" register "type" = "UPC_TYPE_INTERNAL" - register "reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPIO_10)" + register "has_power_resource" = "true" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPIO_10)" + # TODO(b/263161283): Confirm the delay meets the requirement of all BT controllers + register "enable_delay_ms" = "500" + register "enable_off_delay_ms" = "200" + register "use_gpio_for_status" = "true" device usb 2.0 alias usb2_port5 on end end end