intel/apollolake: Do not halt in poweroff if in SMM
Calling halt in poweroff when in SMM prevents SLP_SMI to be triggered preventing the system from entering sleep state. Fix this by calling halt only if ENV_SMM is not true. BUG=chrome-os-partner:56395 BRANCH=None TEST=Verified lidclose behavior on reef. Change-Id: If116c8f4e867543abdc2ff235457c167b5073767 Signed-off-by: Furquan Shaikh <furquan@google.com> Reviewed-on: https://review.coreboot.org/16257 Tested-by: build bot (Jenkins) Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
parent
200f11eb87
commit
3828e55a8c
|
@ -443,5 +443,12 @@ void vboot_platform_prepare_reboot(void)
|
||||||
void poweroff(void)
|
void poweroff(void)
|
||||||
{
|
{
|
||||||
enable_pm1_control(SLP_EN | (SLP_TYP_S5 << SLP_TYP_SHIFT));
|
enable_pm1_control(SLP_EN | (SLP_TYP_S5 << SLP_TYP_SHIFT));
|
||||||
|
|
||||||
|
/*
|
||||||
|
* Setting SLP_TYP_S5 in PM1 triggers SLP_SMI, which is handled by SMM
|
||||||
|
* to transition to S5 state. If halt is called in SMM, then it prevents
|
||||||
|
* the SMI handler from being triggered and system never enters S5.
|
||||||
|
*/
|
||||||
|
if (!ENV_SMM)
|
||||||
halt();
|
halt();
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue