From 38a8fb0c1891bbe3b53965e04c1c7ebcc00654da Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ky=C3=B6sti=20M=C3=A4lkki?= Date: Mon, 30 Jun 2014 13:48:18 +0300 Subject: [PATCH] x86 MTRR: Drop unused return value MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit It was never well-defined what value this function should return. Change-Id: If84aff86e0b556591d7ad557842910a2dfcd3b46 Signed-off-by: Kyösti Mälkki Reviewed-on: http://review.coreboot.org/6166 Tested-by: build bot (Jenkins) Reviewed-by: Patrick Georgi Reviewed-by: Edward O'Callaghan --- src/cpu/x86/mtrr/mtrr.c | 3 +-- src/include/cpu/x86/mtrr.h | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/cpu/x86/mtrr/mtrr.c b/src/cpu/x86/mtrr/mtrr.c index 8826535528..b19b853196 100644 --- a/src/cpu/x86/mtrr/mtrr.c +++ b/src/cpu/x86/mtrr/mtrr.c @@ -772,7 +772,7 @@ void x86_setup_mtrrs(void) x86_setup_var_mtrrs(address_size, 1); } -int x86_mtrr_check(void) +void x86_mtrr_check(void) { /* Only Pentium Pro and later have MTRR */ msr_t msr; @@ -795,5 +795,4 @@ int x86_mtrr_check(void) printk(BIOS_DEBUG, "\n"); post_code(0x93); - return ((int) msr.lo); } diff --git a/src/include/cpu/x86/mtrr.h b/src/include/cpu/x86/mtrr.h index 2a440723b8..95cabf1247 100644 --- a/src/include/cpu/x86/mtrr.h +++ b/src/include/cpu/x86/mtrr.h @@ -66,7 +66,7 @@ void enable_fixed_mtrr(void); void x86_setup_fixed_mtrrs(void); /* Set up fixed MTRRs but do not enable them. */ void x86_setup_fixed_mtrrs_no_enable(void); -int x86_mtrr_check(void); +void x86_mtrr_check(void); #endif #if !defined(__ASSEMBLER__) && defined(__PRE_RAM__) && !defined(__ROMCC__)