GNUBoot
/
coreboot-kgpe-d16
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

device/pci_device.c: Remove unused variable attr setting 

In procedure pci_get_resource, when setting an IO mapped base address,
variable attr is &= with PCI_BASE_ADDRESS_IO_ATTR_MASK. However, in this
particular code flow variable attr is not used later. Remove the line.

BUG=b:112253891
TEST=Build and boot grunt.

Change-Id: Ia4fdda1be92d22017a7a913a911db15aaa440b69
Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com>
Reviewed-on: https://review.coreboot.org/27928
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Martin Roth <martinroth@google.com>
This commit is contained in:
Richard Spiegel 2018-08-07 07:53:36 -07:00 committed by Martin Roth
parent d3131e4164
commit 38ad45c893
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/device/pci_device.c
View File

@ -249,7 +249,6 @@ struct resource *pci_get_resource(struct device *dev, unsigned long index)
resource->flags = 0; resource->flags = 0;
} else if (attr & PCI_BASE_ADDRESS_SPACE_IO) { } else if (attr & PCI_BASE_ADDRESS_SPACE_IO) {
/* An I/O mapped base address. */ /* An I/O mapped base address. */
attr &= PCI_BASE_ADDRESS_IO_ATTR_MASK;
resource->flags |= IORESOURCE_IO; resource->flags |= IORESOURCE_IO;
/* I don't want to deal with 32bit I/O resources. */ /* I don't want to deal with 32bit I/O resources. */
resource->limit = 0xffff; resource->limit = 0xffff;