From 38bbff47a718146887692e36c950094d0801a46c Mon Sep 17 00:00:00 2001 From: Martin Roth Date: Sun, 21 Aug 2022 13:49:37 -0600 Subject: [PATCH] util/lint/lint: Add -I option to invert test results To test the linters, we want to invert the results so that any test that passes shows up as a failure. This will allow us to verify that all of the linters are working correctly. This will be tested nightly as well as on changes to the lint tools. Signed-off-by: Martin Roth Change-Id: Ia8024c6ab0c91fd9f630f37dc802ed3bc6b4608c Reviewed-on: https://review.coreboot.org/c/coreboot/+/67193 Tested-by: build bot (Jenkins) Reviewed-by: Raul Rangel --- util/lint/lint | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/util/lint/lint b/util/lint/lint index c9561a47ca..94cd4a6253 100755 --- a/util/lint/lint +++ b/util/lint/lint @@ -6,6 +6,7 @@ #set -x # uncomment for debug JUNIT=0 +INVERT=0 usage () { printf "Usage: %s [Options]\n" "$0" @@ -16,6 +17,7 @@ usage () { printf " Options:\n" printf " -h | --help : Show this help message\n" + printf " -I | --invert : Invert results - used for testing linters\n" printf " -J | --junit : Send test output to a JUnit file\n" printf "\n" } @@ -27,7 +29,7 @@ junit_write () { fi } -if ! cmd_args="$(getopt -l help,junit -o hJ -- "$@")"; then +if ! cmd_args="$(getopt -l help,junit,invert -o hIJ -- "$@")"; then usage exit 0 fi @@ -39,6 +41,9 @@ while true; do usage exit 0 ;; + -I | --invert) + INVERT=1 + ;; -J | --junit) echo "selected junit" JUNIT=1 @@ -81,7 +86,10 @@ for script in "$(dirname "$0")/${1}-"*; do $script | tee "$LINTLOG" #if the lint script gives any output, that's a failure - if [ "$(wc -l < "$LINTLOG")" -eq 0 ]; then + if [ "${INVERT}" -eq 1 ] && [ "$(wc -l < "$LINTLOG")" -ne 0 ]; then + echo "success" + junit_write " " + elif [ "${INVERT}" -eq 0 ] && [ "$(wc -l < "$LINTLOG")" -eq 0 ]; then echo "success" junit_write " " else