From 38e4a2d4cf3398d56640b03371ff1bd08b30aff5 Mon Sep 17 00:00:00 2001 From: Subrata Banik Date: Wed, 5 May 2021 19:34:07 +0530 Subject: [PATCH] include/console: Fix duplicate entry of postcode 0x79 Change POST_PRE_HARDWAREMAIN postcode value from 0x79 to 0x6e to avoid duplicate entry. Change-Id: I50cc75cd3097fba3e7faff05188511bba69ef1e7 Signed-off-by: Subrata Banik Reviewed-on: https://review.coreboot.org/c/coreboot/+/52895 Tested-by: build bot (Jenkins) Reviewed-by: Furquan Shaikh Reviewed-by: Marshall Dawson --- src/arch/x86/c_start.S | 2 +- src/include/console/post_codes.h | 14 +++++++------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/arch/x86/c_start.S b/src/arch/x86/c_start.S index 19532d82dc..f55ab6e06e 100644 --- a/src/arch/x86/c_start.S +++ b/src/arch/x86/c_start.S @@ -89,7 +89,7 @@ _start: * bss is cleared. Now we call the main routine and * let it do the rest. */ - post_code(POST_PRE_HARDWAREMAIN) /* post fe */ + post_code(POST_PRE_HARDWAREMAIN) /* post 6e */ andl $0xFFFFFFF0, %esp diff --git a/src/include/console/post_codes.h b/src/include/console/post_codes.h index 677cd36545..9682e4db6c 100644 --- a/src/include/console/post_codes.h +++ b/src/include/console/post_codes.h @@ -104,6 +104,13 @@ */ #define POST_ENABLING_CACHE 0x60 +/** + * \brief Pre call to RAM stage main() + * + * POSTed right before RAM stage main() is called from c_start.S + */ +#define POST_PRE_HARDWAREMAIN 0x6e + /** * \brief Before Device Probe * @@ -174,13 +181,6 @@ */ #define POST_BS_WRITE_TABLES 0x79 -/** - * \brief Pre call to RAM stage main() - * - * POSTed right before RAM stage main() is called from c_start.S - */ -#define POST_PRE_HARDWAREMAIN 0x79 - /** * \brief Load Payload *