From 39e6f85ea2c1be74750a16bb2ab7a3892a7b5db1 Mon Sep 17 00:00:00 2001 From: Yu-Ping Wu Date: Mon, 14 Mar 2022 16:53:59 +0800 Subject: [PATCH] soc/mediatek: Set soc_ops.set_resources as no-op Without setting the set_resources field for soc_ops, we will get an error during device initialization: [ERROR] CPU_CLUSTER: 0 missing set_resources Because the set_resources field is considered mandatory, explicitly set it as no-op noop_set_resources. BUG=b:224419346 TEST=emerge-corsola coreboot TEST=Did not see the error on krabby BRANCH=none Change-Id: Ic82b86f0482a9de09e942c1674be5f0ac615851f Signed-off-by: Yu-Ping Wu Reviewed-on: https://review.coreboot.org/c/coreboot/+/62785 Tested-by: build bot (Jenkins) Reviewed-by: Paul Menzel Reviewed-by: Hung-Te Lin --- src/soc/mediatek/mt8173/soc.c | 1 + src/soc/mediatek/mt8183/soc.c | 1 + src/soc/mediatek/mt8186/soc.c | 1 + src/soc/mediatek/mt8192/soc.c | 1 + src/soc/mediatek/mt8195/soc.c | 1 + 5 files changed, 5 insertions(+) diff --git a/src/soc/mediatek/mt8173/soc.c b/src/soc/mediatek/mt8173/soc.c index ef571303de..7a4eeb68a6 100644 --- a/src/soc/mediatek/mt8173/soc.c +++ b/src/soc/mediatek/mt8173/soc.c @@ -21,6 +21,7 @@ static void soc_init(struct device *dev) static struct device_operations soc_ops = { .read_resources = soc_read_resources, + .set_resources = noop_set_resources, .init = soc_init, }; diff --git a/src/soc/mediatek/mt8183/soc.c b/src/soc/mediatek/mt8183/soc.c index 6bcd4d0e24..c2e7d26051 100644 --- a/src/soc/mediatek/mt8183/soc.c +++ b/src/soc/mediatek/mt8183/soc.c @@ -23,6 +23,7 @@ static void soc_init(struct device *dev) static struct device_operations soc_ops = { .read_resources = soc_read_resources, + .set_resources = noop_set_resources, .init = soc_init, }; diff --git a/src/soc/mediatek/mt8186/soc.c b/src/soc/mediatek/mt8186/soc.c index 7686986e71..53e50654e6 100644 --- a/src/soc/mediatek/mt8186/soc.c +++ b/src/soc/mediatek/mt8186/soc.c @@ -32,6 +32,7 @@ static void soc_init(struct device *dev) static struct device_operations soc_ops = { .read_resources = soc_read_resources, + .set_resources = noop_set_resources, .init = soc_init, }; diff --git a/src/soc/mediatek/mt8192/soc.c b/src/soc/mediatek/mt8192/soc.c index 006a212da9..cf1fe48c84 100644 --- a/src/soc/mediatek/mt8192/soc.c +++ b/src/soc/mediatek/mt8192/soc.c @@ -37,6 +37,7 @@ static void soc_init(struct device *dev) static struct device_operations soc_ops = { .read_resources = soc_read_resources, + .set_resources = noop_set_resources, .init = soc_init, }; diff --git a/src/soc/mediatek/mt8195/soc.c b/src/soc/mediatek/mt8195/soc.c index 995aadc8db..cf9f412ae8 100644 --- a/src/soc/mediatek/mt8195/soc.c +++ b/src/soc/mediatek/mt8195/soc.c @@ -43,6 +43,7 @@ static void soc_init(struct device *dev) static struct device_operations soc_ops = { .read_resources = soc_read_resources, + .set_resources = noop_set_resources, .init = soc_init, };