intel/kunimitsu: fix SCI handling

Ported below patch from glados to kunimitsu:

glados: Abstract board GPIO configuration in gpio.h
Original-change-Id: I3f1754012158dd5c7d5bbd6e07e40850f21af56d
Originally-signed-off-by: Duncan Laurie <dlaurie@chromium.org>
Originally-reviewed-on: https://chromium-review.googlesource.com/293942

BUG=chrome-os-partner:40828
BRANCH=none
TEST=Verify that acpi interrupts are incrementing on kunimitsu.

Change-Id: Ifeddb34289b6e62c936cf6c542906d6e7ef96ddd
Signed-off-by: Patrick Georgi <patrick@georgi-clan.de>
Original-Commit-Id: 8ff0dd2dcdf6485f0171fb967f7de3015cf4e4ad
Original-Change-Id: I1f270a03a241d2285639f79854d04059d2c2c99f
Original-Signed-off-by: Wenkai Du <wenkai.du@intel.com>
Original-Reviewed-on: https://chromium-review.googlesource.com/295048
Original-Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Original-Reviewed-by: Robbie Zhang <robbie.zhang@intel.com>
Original-Tested-by: Robbie Zhang <robbie.zhang@intel.com>
Reviewed-on: http://review.coreboot.org/11432
Tested-by: build bot (Jenkins)
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
Wenkai Du 2015-08-24 10:31:30 -07:00 committed by Patrick Georgi
parent 1105fad6ea
commit 3b169252ea
7 changed files with 33 additions and 10 deletions

View File

@ -18,7 +18,11 @@
* Foundation, Inc. * Foundation, Inc.
*/ */
#include "../gpio.h"
Name (OIPG, Package () { Name (OIPG, Package () {
Package () { 0x0001, 0, 0xFFFFFFFF, "INT3437:00" }, // no recovery button /* No physical recovery GPIO. */
Package () { 0x0003, 1, 16, "INT3437:00" }, // firmware write protect Package () { 0x0001, 0, 0xFFFFFFFF, "INT344B:00" },
/* Firmware write protect GPIO. */
Package () { 0x0003, 1, GPIO_PCH_WP, "INT344B:00" },
}) })

View File

@ -18,7 +18,8 @@
*/ */
/* mainboard configuration */ /* mainboard configuration */
#include <mainboard/intel/kunimitsu/ec.h> #include "../ec.h"
#include "../gpio.h"
/* Enable EC backed PD MCU device in ACPI */ /* Enable EC backed PD MCU device in ACPI */
#define EC_ENABLE_PD_MCU_DEVICE #define EC_ENABLE_PD_MCU_DEVICE

View File

@ -18,6 +18,8 @@
* Foundation, Inc. * Foundation, Inc.
*/ */
#include "../gpio.h"
#define BOARD_TRACKPAD_IRQ 0x33 #define BOARD_TRACKPAD_IRQ 0x33
#define BOARD_TOUCHSCREEN_IRQ 0x1f #define BOARD_TOUCHSCREEN_IRQ 0x1f
@ -36,6 +38,8 @@ Scope (\_SB)
{ {
Return (\_SB.PCI0.LPCB.EC0.LIDS) Return (\_SB.PCI0.LPCB.EC0.LIDS)
} }
Name (_PRW, Package () { GPE_EC_WAKE, 5 })
} }
Device (PWRB) Device (PWRB)

View File

@ -26,6 +26,9 @@
#include <string.h> #include <string.h>
#include <vendorcode/google/chromeos/chromeos.h> #include <vendorcode/google/chromeos/chromeos.h>
#include "gpio.h"
#include "ec.h"
#if ENV_RAMSTAGE #if ENV_RAMSTAGE
#include <boot/coreboot_tables.h> #include <boot/coreboot_tables.h>

View File

@ -22,11 +22,6 @@
#define MAINBOARD_EC_H #define MAINBOARD_EC_H
#include <ec/google/chromeec/ec_commands.h> #include <ec/google/chromeec/ec_commands.h>
#include <soc/gpio.h>
/* GPP_E16 is EC_SCI_L */
#define EC_SCI_GPI 16 /* TODO: Update this */
#define EC_SMI_GPI GPP_E15
#define MAINBOARD_EC_SCI_EVENTS \ #define MAINBOARD_EC_SCI_EVENTS \
(EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_CLOSED) |\ (EC_HOST_EVENT_MASK(EC_HOST_EVENT_LID_CLOSED) |\

15
src/mainboard/intel/kunimitsu/gpio.h Normal file → Executable file
View File

@ -21,8 +21,21 @@
#ifndef MAINBOARD_GPIO_H #ifndef MAINBOARD_GPIO_H
#define MAINBOARD_GPIO_H #define MAINBOARD_GPIO_H
#include <soc/gpe.h>
#include <soc/gpio.h> #include <soc/gpio.h>
/* EC in RW */
#define GPIO_EC_IN_RW GPP_C6
/* BIOS Flash Write Protect */
#define GPIO_PCH_WP GPP_C23
/* EC wake is LAN_WAKE# which is a special DeepSX wake pin */
#define GPE_EC_WAKE GPE0_LAN_WAK
/* GPP_E16 is EC_SCI_L. GPP_E group is routed to dword 2 in the GPE0 block. */
#define EC_SCI_GPI GPE0_DW2_16
#define EC_SMI_GPI GPP_E15
#ifndef __ACPI__
/* Pad configuration in ramstage. */ /* Pad configuration in ramstage. */
static const struct pad_config gpio_table[] = { static const struct pad_config gpio_table[] = {
/* EC_PCH_RCIN */ PAD_CFG_NF(GPP_A0, NONE, DEEP, NF1), /* EC_PCH_RCIN */ PAD_CFG_NF(GPP_A0, NONE, DEEP, NF1),
@ -198,3 +211,5 @@ static const struct pad_config early_gpio_table[] = {
}; };
#endif #endif
#endif

View File

@ -28,6 +28,7 @@
#include <soc/pm.h> #include <soc/pm.h>
#include <soc/smm.h> #include <soc/smm.h>
#include "ec.h" #include "ec.h"
#include "gpio.h"
int mainboard_io_trap_handler(int smif) int mainboard_io_trap_handler(int smif)
{ {