mb/google/poppy: Remove digitizer reset control from ACPI
Digitizer power is not controlled by SoC. Also, since the digitizer uses I2C-HID driver in Linux kernel, the device is put into sleep anytime system is suspended. Thus, there is no need to control the reset gpio using ACPI power resource. TEST=Verified that digitizer device is properly detected on boot-up and after suspend/resume. Change-Id: Id11b8412d0ac48b2701d53b0a22ad3b747b544ec Signed-off-by: Furquan Shaikh <furquan@chromium.org> Reviewed-on: https://review.coreboot.org/23212 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Aaron Durbin <adurbin@chromium.org>
This commit is contained in:
parent
a4b253a4b4
commit
3b543a2dfe
|
@ -311,10 +311,6 @@ chip soc/intel/skylake
|
|||
register "generic.desc" = ""WCOM Digitizer""
|
||||
register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_D1_IRQ)"
|
||||
register "generic.wake" = "GPE0_DW1_12"
|
||||
register "generic.has_power_resource" = "1"
|
||||
register "generic.disable_gpio_export_in_crs" = "1"
|
||||
register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_D3)"
|
||||
register "generic.reset_delay_ms" = "1"
|
||||
register "hid_desc_reg_offset" = "0x1"
|
||||
device i2c 0x9 on end
|
||||
end
|
||||
|
|
|
@ -167,7 +167,7 @@ static const struct pad_config gpio_table[] = {
|
|||
/* D2 : SPI1_MISO ==> PEN_PDCT_L */
|
||||
PAD_CFG_GPI_GPIO_DRIVER(GPP_D2, NONE, DEEP),
|
||||
/* D3 : SPI1_MOSI ==> PEN_RST_L */
|
||||
PAD_CFG_GPO(GPP_D3, 0, DEEP),
|
||||
PAD_CFG_GPO(GPP_D3, 1, DEEP),
|
||||
/* D4 : FASHTRIG ==> LTE_GPS_OFF_ODL */
|
||||
PAD_CFG_GPO(GPP_D4, 1, DEEP),
|
||||
/* D5 : ISH_I2C0_SDA ==> ISH_I2C_SENSOR_1V8_SDA */
|
||||
|
|
Loading…
Reference in New Issue